Nouveau - Apr 2012 - [PATCH] nv50: fix crash in NV50SyncToVBlank

Regression from "WIP: port to new libdrm".
---
 src/nv50_accel.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/nv50_accel.c b/src/nv50_accel.c
index 66d6cb8..7c640f2 100644
--- a/src/nv50_accel.c
+++ b/src/nv50_accel.c
@@ -44,6 +44,9 @@ NV50SyncToVBlank(PixmapPtr ppix, BoxPtr box)
 	if (!crtcs)
 		return;
 
+	if (!PUSH_SPACE(push, 10))
+		return;
+
 	BEGIN_NV04(push, SUBC_NVSW(0x0060), 2);
 	PUSH_DATA (push, pNv->vblank_sem->handle);
 	PUSH_DATA (push, 0);
-- 
1.7.8.5

On Sun, Apr 15, 2012 at 01:46:42PM +0200, Marcin Slusarz
wrote:
> Regression from "WIP: port to new libdrm".
> ---
>  src/nv50_accel.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/src/nv50_accel.c b/src/nv50_accel.c
> index 66d6cb8..7c640f2 100644
> --- a/src/nv50_accel.c
> +++ b/src/nv50_accel.c
> @@ -44,6 +44,9 @@ NV50SyncToVBlank(PixmapPtr ppix, BoxPtr box)
>  	if (!crtcs)
>  		return;
>  
> +	if (!PUSH_SPACE(push, 10))
> +		return;
> +
>  	BEGIN_NV04(push, SUBC_NVSW(0x0060), 2);
>  	PUSH_DATA (push, pNv->vblank_sem->handle);
>  	PUSH_DATA (push, 0);
> -- 
Nobody uses "sync to vblank"? It's crashy as hell without this
patch...

Marcin