Nouveau - Aug 2009 - [Bug 23295] New: nouveau KMS: null pointer dereference if native mode is not found

http://bugs.freedesktop.org/show_bug.cgi?id=23295

           Summary: nouveau KMS: null pointer dereference if native mode is
                    not found
           Product: xorg
           Version: git
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
        AssignedTo: nouveau at lists.freedesktop.org
        ReportedBy: anssi at mandriva.org
         QAContact: xorg-team at lists.x.org


When native mode is not found by KMS, at least with NV40, there is a null
pointer dereference of native_mode in nv_output_mode_fixup() when starting X.

Kernel log attached.

(In this case native mode is not found because of "Output script table
version
0x11 unknown"; I'll open a separate bug for that with proper info if
none is
already open)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=23295





--- Comment #1 from Anssi Hannula <anssi at mandriva.org>  2009-08-13
14:54:13 PST ---
Created an attachment (id=28607)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=28607)
kernel log of native_mode null pointer dereference


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=23295





--- Comment #2 from Ben Skeggs <skeggsb at gmail.com>  2009-08-13 15:14:14
PST ---
The output script table messages are harmless, and not the cause of your issue.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=23295





--- Comment #3 from Anssi Hannula <anssi at mandriva.org>  2009-08-13
15:20:24 PST ---
Ok. Should I still open a bugreport for the fact that the native mode is not
found, with vbios dumps etc?
I'd consider this report to be about the missing failure path here, not the
fact that it fails :)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=23295





--- Comment #4 from Anssi Hannula <anssi at mandriva.org>  2009-08-14
09:22:11 PST ---
drm_edid.c ignores detailed timings on EDID < 1.3, and this LVDS has 1.2,
causing no modes found, triggering this issue.
I'll report the EDID parsing one separately elsewhere, as it is a
non-nouveau
issue.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=23295





--- Comment #5 from Anssi Hannula <anssi at mandriva.org>  2009-08-20
17:24:45 PST ---
The EDID parsing issue has been fixed in drm git.

As for this bug, I sent a patch to nouveau mailinglist some days ago, it is
awaiting review. "drm/nv04: fix null pointer dereferences of
native_mode"


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=23295


Francisco Jerez <currojerez at riseup.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #6 from Francisco Jerez <currojerez at riseup.net>  2009-09-17
04:16:01 PST ---
(In reply to comment #5)
> The EDID parsing issue has been fixed in drm git.
> 
> As for this bug, I sent a patch to nouveau mailinglist some days ago, it is
> awaiting review. "drm/nv04: fix null pointer dereferences of
native_mode"
> 
It's already pushed so I'm marking this as fixed.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.