Nouveau - Aug 2009 - [Bug 23291] New: A slight problem in the NV50 nouveau driver in Mesa

http://bugs.freedesktop.org/show_bug.cgi?id=23291

           Summary: A slight problem in the NV50 nouveau driver in Mesa
           Product: Mesa
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: medium
         Component: Drivers/DRI/nouveau
        AssignedTo: nouveau at lists.freedesktop.org
        ReportedBy: STEVENWARD666 at hotmail.com


Hi all,
      I've been compiling Mesa for some time now from git.
I don't know if anyone is aware of this build error,but after todays commits
to
the git repository,I come up with build error when I run make:

gcc -c -I. -I../../../../src/gallium/include
-I../../../../src/gallium/auxiliary -I../../../../src/gallium/drivers
-I/src/gallium/include -I/src/gallium/auxiliary -I/src/gallium/drivers  -g -O2
-Wall -Wmissing-prototypes -std=c99 -ffast-math -fno-strict-aliasing -m32 
-fPIC  -DUSE_X86_ASM -DUSE_MMX_ASM -DUSE_3DNOW_ASM -DUSE_SSE_ASM -D_GNU_SOURCE
-DPTHREADS -DHAVE_POSIX_MEMALIGN -DUSE_XCB -DUSE_EXTERNAL_DXTN_LIB=1
-DIN_DRI_DRIVER -DGLX_DIRECT_RENDERING -DGLX_INDIRECT_RENDERING -DHAVE_ALIAS 
nv50_program.c -o nv50_program.o
nv50_program.c: In function ?ctor_immd?:
nv50_program.c:299: error: ?r? undeclared (first use in this function)
nv50_program.c:299: error: (Each undeclared identifier is reported only once
nv50_program.c:299: error: for each function it appears in.)
gmake[4]: *** [nv50_program.o] Error 1
gmake[4]: Leaving directory `/opt/mesa/src/gallium/drivers/nv50'
gmake[3]: *** [default] Error 1
gmake[3]: Leaving directory `/opt/mesa/src/gallium/drivers'
gmake[2]: *** [default] Error 1
gmake[2]: Leaving directory `/opt/mesa/src/gallium'
make[1]: *** [subdirs] Error 1
make[1]: Leaving directory `/opt/mesa/src'
make: *** [default] Error 1

Regards,
       STEVE555


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=23291


Renato Caldas <seventhguardian at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |seventhguardian at gmail.com
           Severity|minor                       |blocker
            Summary|A slight problem in the NV50|nv50_program.c: In function
                   |nouveau driver in Mesa      |?ctor_immd?, ?r?
                   |                            |undeclared (first use in
                   |                            |this function)




--- Comment #1 from Renato Caldas <seventhguardian at gmail.com> 
2009-08-14 05:31:28 PST ---
Please, use descriptive summaries for bug reports.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=23291





--- Comment #2 from Steven Ward <STEVENWARD666 at hotmail.com>  2009-08-14
06:11:13 PST ---
Hi there,
        I'm sorry about that,here is some more detail.I'm currently
using
Fedora 12 Rawhide Alpha.My Graphics Card is a Nividia Geforce 6,800 G.T,my
Monitor is a A.D.I Microscan G1,000.I compile D.R.M,The Nouveau Kernel Modules
from the nouveaulinux-2.6 repository,Mesa and the Nouveau Driver.All from their
respective git repositories.

The one I'm having trouble with(hence the error report for it),is from the
Mesa
code.
The ./configure options are:
./configure --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin
--sbindir=/usr/sbin --datadir=/usr/share --sysconfdir=/etc
--includedir=/usr/include --libdir=/usr/lib --libexecdir=/usr/libexec
--localstatedir=/var --mandir=/usr/share/man --docdir=/usr/share/doc
--x-libraries=/usr/lib --enable-32-bit --enable-xcb --enable-gallium-nouveau
--with-x --with-dri-driverdir=/usr/lib/dri
--with-xorg-driver-dir=/usr/lib/xorg/modules/drivers
--with-state-trackers=dri,egl,xorg,glx,vega,g3dvl --enable-motif
--enable-gl-osmesa --with-osmesa-bits=32 --disable-gallium-intel
--disable-gallium-radeon --with-expat=/usr/lib
--with-demos=xdemos,demos,trivial,tests --with-dri-drivers=swrast,ffb 

I then run make,and that's where the Mesa code stops when I compile it.

If you need any other information,please let me know.

Regards,
       STEVE555


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=23291


Christoph Bumiller <e0425955 at student.tuwien.ac.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID




--- Comment #3 from Christoph Bumiller <e0425955 at student.tuwien.ac.at> 
2009-08-14 06:36:42 PST ---
Don't submit bug reports for nouveau gallium yet please if you don't
have a
patch to go with it. Thanks.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=23291


Renato Caldas <seventhguardian at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |




--- Comment #4 from Renato Caldas <seventhguardian at gmail.com> 
2009-08-14 06:42:23 PST ---
Hello,

This should be pretty trivial, and I'm working on a patch. Please be patient
:)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=23291





--- Comment #5 from Renato Caldas <seventhguardian at gmail.com> 
2009-08-14 07:26:36 PST ---
Created an attachment (id=28632)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=28632)
Patch that fixes nv50_program.c compilation

Here's the patch.

This seems to be an ancient bug, where one instance of "r" should have
been
replaced by "4" but wasn't. It never caused any problems before,
because the
second REALLOC argument was discarded. This changed with this commit:

[120e76866b4b0d136ae4ed377c6ff96454e39b95] util: silence warnings for third
REALLOC argument


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=23291


Renato Caldas <seventhguardian at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|nv50_program.c: In function |nv50_program.c: In function
                   |?ctor_immd?, ?r?    |?ctor_immd?, ?r?
                   |undeclared (first use in    |undeclared (first use in
                   |this function)              |this function) [PATCH]




-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=23291


Christoph Bumiller <e0425955 at student.tuwien.ac.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #6 from Christoph Bumiller <e0425955 at student.tuwien.ac.at> 
2009-08-14 07:57:49 PST ---
Thanks; I would've put your name under it but I had committed the fix in the
same instant I marked that bug invalid.
Now you're ready to fix the more serious issues; just send a patch to the
nouveau list when you have one instead of opening a bug report though (or
we'd
be swimming in Gallium bugs), until we declare the code ready :-)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=23291





--- Comment #7 from Renato Caldas <seventhguardian at gmail.com> 
2009-08-14 08:03:09 PST ---
(In reply to comment #6)
> Thanks; I would've put your name under it but I had committed the fix
in the
> same instant I marked that bug invalid.
No problem, it was really trivial :)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

http://bugs.freedesktop.org/show_bug.cgi?id=23291





--- Comment #8 from Steven Ward <STEVENWARD666 at hotmail.com>  2009-08-14
14:16:55 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > Thanks; I would've put your name under it but I had committed the
fix in the
> > same instant I marked that bug invalid.
> No problem, it was really trivial :)
> 
Hi there,
        I am sorry about that,I am aware the code is still in a state of flux.
I just wanted to notify that the whole code was stopping at that error,when I
compile.I should've waited a bit longer,but oh well.I wish I could submit
patches,but I don't know anything about C code and I can just about get my
head
round the actual tree itself.Though I do find it interesting watching the
changes.

I like to thank you very much for your help.

Regards,
       STVE555


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.