llvm dev - Feb 2014 - [LLVMdev] Heads-up: changing the structure of compiler-rt source tree

Hi all,

compiler-rt is now not only a libgcc replacement for different platforms,
there are sanitizer and profile runtimes as well. I plan to move the files
as follows during this week:

1. libraries:
a) all libgcc replacement stuff moves from "/lib" to
"/lib/core" (the name
sucks, please suggest alternatives). Same for platform-specific code:
"/lib/arm/"->"/lib/core/arm",
"/lib/i386"->"/lib/core/i386" etc.
b) "/BlocksRuntime"->"/lib/BlocksRuntime"
c) "/lib/sanitizer_common", "/lib/xsan",
"/lib/profile" are not moved.

2. tests:
all tests (lit tests and unit tests) are moved from directories under
"/lib" to "/test" to be consistent with LLVM/Clang test
subtrees.

See the original mail from Chandler for the overview of compiler-rt tree
current state and suggestion to change its structure:
http://clang-developers.42468.n3.nabble.com/Sanitizers-libs-in-Compiler-RT-tp4037520p4037567.html

Please speak up if you disagree with this.

-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140211/07c96b42/attachment.html>

Hi Alexey,

"rt" could be an alternative to "core", but really, either
are equally bad. :)

LGTM either way.

cheers,
--renato

On 11 February 2014 09:59, Alexey Samsonov <samsonov at google.com>
wrote:
> Hi all,
>
> compiler-rt is now not only a libgcc replacement for different platforms,
> there are sanitizer and profile runtimes as well. I plan to move the files
> as follows during this week:
>
> 1. libraries:
> a) all libgcc replacement stuff moves from "/lib" to
"/lib/core" (the name
> sucks, please suggest alternatives). Same for platform-specific code:
> "/lib/arm/"->"/lib/core/arm",
"/lib/i386"->"/lib/core/i386" etc.
> b) "/BlocksRuntime"->"/lib/BlocksRuntime"
> c) "/lib/sanitizer_common", "/lib/xsan",
"/lib/profile" are not moved.
>
> 2. tests:
> all tests (lit tests and unit tests) are moved from directories under
"/lib"
> to "/test" to be consistent with LLVM/Clang test subtrees.
>
> See the original mail from Chandler for the overview of compiler-rt tree
> current state and suggestion to change its structure:
>
http://clang-developers.42468.n3.nabble.com/Sanitizers-libs-in-Compiler-RT-tp4037520p4037567.html
>
> Please speak up if you disagree with this.
>
> --
> Alexey Samsonov, MSK

On 11 Feb 2014, at 10:59, Alexey Samsonov <samsonov at google.com>
wrote:
> compiler-rt is now not only a libgcc replacement for different platforms,
there are sanitizer and profile runtimes as well. I plan to move the files as
follows during this week:
> 
> 1. libraries:
> a) all libgcc replacement stuff moves from "/lib" to
"/lib/core" (the name sucks, please suggest alternatives). Same for
platform-specific code: "/lib/arm/"->"/lib/core/arm",
"/lib/i386"->"/lib/core/i386" etc.
Maybe just lib/runtime (assuming that "rt" was shorthand for it)? :-)

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 203 bytes
Desc: Message signed with OpenPGP using GPGMail
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140211/54a465e4/attachment.sig>

According to the makefile, the module is called "builtins", perhaps
the
directory should be called the same?


On Tue, Feb 11, 2014 at 1:59 AM, Alexey Samsonov <samsonov at
google.com>wrote:
> Hi all,
>
> compiler-rt is now not only a libgcc replacement for different platforms,
> there are sanitizer and profile runtimes as well. I plan to move the files
> as follows during this week:
>
> 1. libraries:
> a) all libgcc replacement stuff moves from "/lib" to
"/lib/core" (the name
> sucks, please suggest alternatives). Same for platform-specific code:
> "/lib/arm/"->"/lib/core/arm",
"/lib/i386"->"/lib/core/i386" etc.
> b) "/BlocksRuntime"->"/lib/BlocksRuntime"
> c) "/lib/sanitizer_common", "/lib/xsan",
"/lib/profile" are not moved.
>
> 2. tests:
> all tests (lit tests and unit tests) are moved from directories under
> "/lib" to "/test" to be consistent with LLVM/Clang test
subtrees.
>
> See the original mail from Chandler for the overview of compiler-rt tree
> current state and suggestion to change its structure:
>
>
http://clang-developers.42468.n3.nabble.com/Sanitizers-libs-in-Compiler-RT-tp4037520p4037567.html
>
> Please speak up if you disagree with this.
>
> --
> Alexey Samsonov, MSK
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140211/5feb79fd/attachment.html>

Yes, I think "builtins" makes more sense than "runtime" or
"core". Thanks
for suggestion!


On Wed, Feb 12, 2014 at 10:27 AM, Vadim Chugunov <vadimcn at gmail.com>
wrote:
> According to the makefile, the module is called "builtins",
perhaps the
> directory should be called the same?
>
>
> On Tue, Feb 11, 2014 at 1:59 AM, Alexey Samsonov <samsonov at
google.com>wrote:
>
>> Hi all,
>>
>> compiler-rt is now not only a libgcc replacement for different
platforms,
>> there are sanitizer and profile runtimes as well. I plan to move the
files
>> as follows during this week:
>>
>> 1. libraries:
>> a) all libgcc replacement stuff moves from "/lib" to
"/lib/core" (the
>> name sucks, please suggest alternatives). Same for platform-specific
code:
>> "/lib/arm/"->"/lib/core/arm",
"/lib/i386"->"/lib/core/i386" etc.
>> b) "/BlocksRuntime"->"/lib/BlocksRuntime"
>> c) "/lib/sanitizer_common", "/lib/xsan",
"/lib/profile" are not moved.
>>
>> 2. tests:
>> all tests (lit tests and unit tests) are moved from directories under
>> "/lib" to "/test" to be consistent with LLVM/Clang
test subtrees.
>>
>> See the original mail from Chandler for the overview of compiler-rt
tree
>> current state and suggestion to change its structure:
>>
>>
http://clang-developers.42468.n3.nabble.com/Sanitizers-libs-in-Compiler-RT-tp4037520p4037567.html
>>
>> Please speak up if you disagree with this.
>>
>> --
>> Alexey Samsonov, MSK
>>
>> _______________________________________________
>> LLVM Developers mailing list
>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>>
>>
>

-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140212/f57cf08d/attachment.html>

Are you going to move the unwind library there as part of the reorganisation?

David

On 11 Feb 2014, at 09:59, Alexey Samsonov <samsonov at google.com> wrote:
> Hi all,
> 
> compiler-rt is now not only a libgcc replacement for different platforms,
there are sanitizer and profile runtimes as well. I plan to move the files as
follows during this week:
> 
> 1. libraries:
> a) all libgcc replacement stuff moves from "/lib" to
"/lib/core" (the name sucks, please suggest alternatives). Same for
platform-specific code: "/lib/arm/"->"/lib/core/arm",
"/lib/i386"->"/lib/core/i386" etc.
> b) "/BlocksRuntime"->"/lib/BlocksRuntime"
> c) "/lib/sanitizer_common", "/lib/xsan",
"/lib/profile" are not moved.
> 
> 2. tests:
> all tests (lit tests and unit tests) are moved from directories under
"/lib" to "/test" to be consistent with LLVM/Clang test
subtrees.
> 
> See the original mail from Chandler for the overview of compiler-rt tree
current state and suggestion to change its structure:
>
http://clang-developers.42468.n3.nabble.com/Sanitizers-libs-in-Compiler-RT-tp4037520p4037567.html
> 
> Please speak up if you disagree with this.
> 
> -- 
> Alexey Samsonov, MSK
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

I would still urge folks to consider keeping distinct functionality in separate
places.

Agreed, it makes more sense for the [language agnostic]  unwinder to be in
compiler-rt than libcxxabi -- but IMO it makes even more sense for it to be
distinct.

The bundling of the unwinder with libgcc_s gave us (i.e. 3rd party folks,
outside the vendor's organisation) nothing but headaches.  Much happier to
see it in libunwind.xxx

Iain

On 12 Feb 2014, at 12:56, David Chisnall wrote:
> Are you going to move the unwind library there as part of the
reorganisation?
> 
> David
> 
> On 11 Feb 2014, at 09:59, Alexey Samsonov <samsonov at google.com>
wrote:
> 
>> Hi all,
>> 
>> compiler-rt is now not only a libgcc replacement for different
platforms, there are sanitizer and profile runtimes as well. I plan to move the
files as follows during this week:
>> 
>> 1. libraries:
>> a) all libgcc replacement stuff moves from "/lib" to
"/lib/core" (the name sucks, please suggest alternatives). Same for
platform-specific code: "/lib/arm/"->"/lib/core/arm",
"/lib/i386"->"/lib/core/i386" etc.
>> b) "/BlocksRuntime"->"/lib/BlocksRuntime"
>> c) "/lib/sanitizer_common", "/lib/xsan",
"/lib/profile" are not moved.
>> 
>> 2. tests:
>> all tests (lit tests and unit tests) are moved from directories under
"/lib" to "/test" to be consistent with LLVM/Clang test
subtrees.
>> 
>> See the original mail from Chandler for the overview of compiler-rt
tree current state and suggestion to change its structure:
>>
http://clang-developers.42468.n3.nabble.com/Sanitizers-libs-in-Compiler-RT-tp4037520p4037567.html
>> 
>> Please speak up if you disagree with this.
>> 
>> -- 
>> Alexey Samsonov, MSK
>> _______________________________________________
>> LLVM Developers mailing list
>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> 
> 
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

On Wed, Feb 12, 2014 at 4:56 PM, David Chisnall <David.Chisnall at
cl.cam.ac.uk
> wrote:
> Are you going to move the unwind library there as part of the
> reorganisation?
>
No.

>
> David
>
> On 11 Feb 2014, at 09:59, Alexey Samsonov <samsonov at google.com>
wrote:
>
> > Hi all,
> >
> > compiler-rt is now not only a libgcc replacement for different
> platforms, there are sanitizer and profile runtimes as well. I plan to move
> the files as follows during this week:
> >
> > 1. libraries:
> > a) all libgcc replacement stuff moves from "/lib" to
"/lib/core" (the
> name sucks, please suggest alternatives). Same for platform-specific code:
> "/lib/arm/"->"/lib/core/arm",
"/lib/i386"->"/lib/core/i386" etc.
> > b) "/BlocksRuntime"->"/lib/BlocksRuntime"
> > c) "/lib/sanitizer_common", "/lib/xsan",
"/lib/profile" are not moved.
> >
> > 2. tests:
> > all tests (lit tests and unit tests) are moved from directories under
> "/lib" to "/test" to be consistent with LLVM/Clang test
subtrees.
> >
> > See the original mail from Chandler for the overview of compiler-rt
tree
> current state and suggestion to change its structure:
> >
>
http://clang-developers.42468.n3.nabble.com/Sanitizers-libs-in-Compiler-RT-tp4037520p4037567.html
> >
> > Please speak up if you disagree with this.
> >
> > --
> > Alexey Samsonov, MSK
> > _______________________________________________
> > LLVM Developers mailing list
> > LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>

-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140212/0eb4d4cf/attachment.html>