Op 20-10-14 om 16:36 schreef Martijn van Beurden:> Op 20-10-14 om 16:31 schreef lvqcl: >> But your patch changes only two last presets (-7 and -8) so >> -6 stays unchanged. ( IIRC it should have >> "tukey(5e-1);partial_tukey(2)" as its apodization string >> instead of current "tukey(5e-1)" ). > > .... okay, I really don't know how it is possible I missed > that. Sorry. Here's the patch again.Sadly, it turns out this patch requires another patch to fix the test_compression.sh test. The LP coefficient approximations don't work well with the noisy-sine.wav file that is used for this test. More explanation is provided in the commit description. -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Make-test_compression-a-little-more-forgiving.patch Type: text/x-patch Size: 0 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20141022/df7dcd26/attachment.bin
Martijn van Beurden wrote:> Sadly, it turns out this patch requires another patch to fix the > test_compression.sh test. The LP coefficient approximations > don't work well with the noisy-sine.wav file that is used for > this test. More explanation is provided in the commit description.By the way, flac --explain lists available window functions in the description of "-A, --apodization" option. And new window functions are not mentioned there. Also, there are several places where presets are described: for example, flac --help and --explain print exact settings for all presets, e.g.: "-6, --compression-level-6 Synonymous with -l 8 -b 4096 -m -r 6"
lvqcl wrote:> By the way, flac --explain lists available window functions in > the description of "-A, --apodization" option. [...]Here's a patch to fix that. -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Update-documentation-for-new-compression-presets.patch Type: text/x-patch Size: 0 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20141110/7b07c3c8/attachment.bin