Martijn van Beurden wrote:> This patch changes the settings associated with compression > levels 6, 7 and 8. With this patch, -e is no longer used, but > instead apodization functions are added. This should improve > compression with at least 95% of all material. Independent tests > show that this is probably the case.But your patch changes only two last presets (-7 and -8) so -6 stays unchanged. ( IIRC it should have "tukey(5e-1);partial_tukey(2)" as its apodization string instead of current "tukey(5e-1)" ).
Op 20-10-14 om 16:31 schreef lvqcl:> But your patch changes only two last presets (-7 and -8) so -6 > stays unchanged. ( IIRC it should have > "tukey(5e-1);partial_tukey(2)" as its apodization string > instead of current "tukey(5e-1)" )..... okay, I really don't know how it is possible I missed that. Sorry. Here's the patch again. -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Retune-FLAC-compression-levels.patch Type: text/x-patch Size: 0 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20141020/47840878/attachment.bin
Op 20-10-14 om 16:36 schreef Martijn van Beurden:> Op 20-10-14 om 16:31 schreef lvqcl: >> But your patch changes only two last presets (-7 and -8) so >> -6 stays unchanged. ( IIRC it should have >> "tukey(5e-1);partial_tukey(2)" as its apodization string >> instead of current "tukey(5e-1)" ). > > .... okay, I really don't know how it is possible I missed > that. Sorry. Here's the patch again.Sadly, it turns out this patch requires another patch to fix the test_compression.sh test. The LP coefficient approximations don't work well with the noisy-sine.wav file that is used for this test. More explanation is provided in the commit description. -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Make-test_compression-a-little-more-forgiving.patch Type: text/x-patch Size: 0 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20141022/df7dcd26/attachment.bin