zfs crypto discuss - Jun 2008 - Review for 5031131 (performance improvement to libcryptoutil) (due July 3)

Here''s a review for a OpenSolaris PKCS11 optimization:
5031131 perf: pkcs11_kernel can benefit from a more efficient pkcs11_mech2str()

http://dan.drydog.com/reviews/5031131-libcryptoutil/

This improves performance for libcryptoutil, used by the pkcs11 libraries.
The improvements are
1) use bsearch(2C) instead of a linear search when looking up the string, given
a crypto mechanism number
2) avoid allocating memory (via strdup) when possible--return a static string.

The first improvement alone improved performance by 66% (as measured in a loop
with 10000000 function calls).  The two improvements combined improved
performance by a total of 76%.

Please respond by COB July 3, 2008.
 
 
This message posted from opensolaris.org

I realized you meant to send this to crypto-discuss, you just got a 
''zfs-'' in the front of it by mistake :)


Dan Anderson wrote:
> Here''s a review for a OpenSolaris PKCS11 optimization:
> 5031131 perf: pkcs11_kernel can benefit from a more efficient
pkcs11_mech2str()
> 
> http://dan.drydog.com/reviews/5031131-libcryptoutil/
> 
> This improves performance for libcryptoutil, used by the pkcs11 libraries.
> The improvements are
> 1) use bsearch(2C) instead of a linear search when looking up the string,
given a crypto mechanism number
> 2) avoid allocating memory (via strdup) when possible--return a static
string.
> 
> The first improvement alone improved performance by 66% (as measured in a
loop with 10000000 function calls).  The two improvements combined improved
performance by a total of 76%.
> 
> Please respond by COB July 3, 2008.
>  
>  
> This message posted from opensolaris.org
> _______________________________________________
> zfs-crypto-discuss mailing list
> zfs-crypto-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/zfs-crypto-discuss