zfs crypto discuss - Jun 2008 - [Bug 2305] New: dnode dn_bonus needs to be encrypted

http://defect.opensolaris.org/bz/show_bug.cgi?id=2305

           Summary: dnode dn_bonus needs to be encrypted
    Classification: Development
           Product: zfs-crypto
           Version: unspecified
          Platform: Other
        OS/Version: Other
            Status: ACCEPTED
          Severity: blocker
          Priority: P1
         Component: other
        AssignedTo: darrenm at opensolaris.org
        ReportedBy: darrenm at opensolaris.org
         QAContact: hua.tang at sun.com
                CC: zfs-crypto-discuss at opensolaris.org
   Estimated Hours: 0.0


Most of the dnode_phys_t content needs to be in the clear so that pool and
dataset traversal will work even when keys are not present.

However there are some cases, notably via the ZPL, where the actual data is
stored inside the dnode_phys_t in dn_bonus.  For those cases we must ensure
that the bonus field is encrypted even when the rest of the dnode_phys_t is in
the clear.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=2305





--- Comment #1 from Darren J Moffat <darrenm at opensolaris.org> 
2008-06-23 07:38:34 ---
$ cd /tank/fs  # where tank/fs has encryption turned on
$ echo "AAAA" > A

I see calls like this:

  0  -> dnode_sync                dnode type = 19 bonustype = 17
  0    -> dbuf_sync_leaf          dnode type = 19 bonustype 17 blkid -1
  0    <- dbuf_sync_leaf
  0    -> dbuf_sync_leaf          dnode type = 19 bonustype 17 blkid 0
  0      -> dbuf_write            crypt = 4
  0        -> arc_write           crypt = 4
  0        <- arc_write
  0      <- dbuf_write
  0    <- dbuf_sync_leaf
  0  <- dnode_sync
  0  -> dnode_sync                dnode type = 20 bonustype = 17
  0    -> dbuf_sync_leaf          dnode type = 20 bonustype 17 blkid -1
  0    <- dbuf_sync_leaf
  0    -> dbuf_sync_leaf          dnode type = 20 bonustype 17 blkid 0
  0      -> dbuf_write            crypt = 4
  0        -> arc_write           crypt = 4
  0        <- arc_write
  0      <- dbuf_write
  0    <- dbuf_sync_leaf
  0  <- dnode_sync

blkid -1 is DB_BONUS_BLKID
type 19 is DMU_OT_PLAIN_FILE_CONTENTS
type 20 is DMU_OT_DIRECTORY_CONTENTS
Both of those have a bonustype of 17 DMU_OT_ZNODE.


I think what this is showing is that the znode_t because it is in the
dnode_phys_t for the file or directory content *is* being encrypted.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=2305


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |BUGSTER:6719749
             Status|ACCEPTED                    |CLOSED
         Resolution|                            |TRACKEDINBUGSTER




--- Comment #2 from Darren J Moffat <darrenm at opensolaris.org> 
2008-06-26 11:16:58 ---
BUGSTER:6719749

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=2305


David Comay <David.Comay at Sun.COM> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |BugsterCR=6719749
                 CC|                            |David.Comay at Sun.COM




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.