zfs crypto discuss - May 2008 - [Bug 2107] New: zfs_key_c_006 test 3: keysource set when key change fails

http://defect.opensolaris.org/bz/show_bug.cgi?id=2107

           Summary: zfs_key_c_006 test 3: keysource set when key change
                    fails
    Classification: Development
           Product: zfs-crypto
           Version: unspecified
          Platform: Other
        OS/Version: Solaris
            Status: NEW
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: ajscarp at yahoo.com
        ReportedBy: ajscarp at yahoo.com
         QAContact: hua.tang at sun.com
                CC: zfs-crypto-discuss at opensolaris.org
   Estimated Hours: 0.0


change a dataset from keyscope pool to keyscope dataset and defining a new
keysource, where the key file doesn''t exist, fails to properly, however
the
keysource is set to the failed value..

-----
Msg| 121114 | 3: new keysource=passphrase,file:///no_file
Msg| 121114 |  
stdout| 121114| /usr/sbin/zpool key -l pool_121114
stdout| 121114| /usr/sbin/zfs create -o encryption=on -o keyscope=pool
pool_1211
14/fs_3
stdout| 121114| /usr/sbin/zfs key -c -o keyscope=dataset -o
keysource=passphrase
,file:///no_file pool_121114/fs_3
stdout| 121114| cannot set property for ''pool_121114/fs_3'':
invalid keysource.
stdout| Key change error: crypto key failure
stdout| 121114| Expected keysource: default
stdout| 121114| Actual keysource: passphrase,file:///no_file
Msg| 121114 | [ - Result ]
Msg| 121114 | RESULT:  FAIL
-----

bash-3.2# zpool create -o keysource=passphrase,prompt tank c0t0d0s6
bash-3.2# zfs create -o encryption=on tank/fs
bash-3.2# zfs key -c -o keysource=passphrase,file:///no_file -o keyscope=datase
t tank/fs
cannot set property for ''tank/fs'': invalid keysource.
Key change error: crypto key failure
bash-3.2# echo $?
1
bash-3.2# zfs get all tank/fs
NAME     PROPERTY         VALUE                       SOURCE
tank/fs  keysource        passphrase,file:///no_file  local
tank/fs  keyscope         pool                        local

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=2107


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|zfs_key_c_006 test 3:       |zfs_key_c_006 test 3 & 5:
                   |keysource set when key      |keysource set when key
                   |change fails                |change fails




--- Comment #1 from ajscarp at yahoo.com  2008-05-30 16:25:43 ---
Test #5 has the same problem.  Only difference is the keysource is hex,prompt.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=2107


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darrenm at opensolaris.org
             Status|NEW                         |CLOSED
         Resolution|                            |DUPLICATE




--- Comment #2 from Darren J Moffat <darrenm at opensolaris.org> 
2008-06-02 07:52:58 ---


*** This bug has been marked as a duplicate of bug 2114 ***

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=2107


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |REOPENED
         Resolution|DUPLICATE                   |




--- Comment #3 from Darren J Moffat <darrenm at opensolaris.org> 
2008-06-02 07:53:54 ---
Wrong close keep forgeting bugzilla shows next bug after commit.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=2107


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ACCEPTED




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=2107


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |CLOSED
         Resolution|                            |FIXINSOURCE




--- Comment #4 from ajscarp at yahoo.com  2008-06-07 19:00:43 ---
test 3:
problem resolved.. valid_keysource_change() is passed zfs_crypto_t, so it can
be less restrictive on keysource validation rules..

test 5:
I think that was a memory corruption caused by memset clearing the passphrase
pointer instead of the *passphrase pointer..

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=2107


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Grace




--- Comment #5 from ajscarp at yahoo.com  2008-06-07 19:02:20 ---
*** Bug 2162 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.