zfs crypto discuss - May 2008 - [Bug 2033] New: ''zfs create'' causes panic if key file doesn''t exist

http://defect.opensolaris.org/bz/show_bug.cgi?id=2033

           Summary: ''zfs create'' causes panic if key file
doesn''t exist
    Classification: Development
           Product: zfs-crypto
           Version: unspecified
          Platform: Other
        OS/Version: Solaris
            Status: NEW
          Severity: minor
          Priority: P2
         Component: other
        AssignedTo: darrenm at opensolaris.org
        ReportedBy: hua.tang at sun.com
         QAContact: hua.tang at sun.com
                CC: zfs-crypto-discuss at opensolaris.org
   Estimated Hours: 0.0


build: zfs-crypto-gate-2008-05-23-18:05

# zpool create -f test /export/home/testfile
# zfs create -o keysource=raw,file:///no_file -o keyscope=dataset -o
encryption=on test/fs

panic info:

panic[cpu0]/thread=2a100a67ca0: assertion failed: 0 == dsl_crypto_key_gen(ds,
zct, cr, tx), file: ../../common/fs/zfs/dmu_objset.c, line: 628

000002a100a675a0 genunix:assfail+78 (7b3036a0, 7b3031a8, 274, 1853800, 1361000,
0)
  %l0-3: 0000030004e520c0 0000060010edd830 000000007b303400 0000060011409328
  %l4-7: 000000007b303400 0000000000000000 00000000018a2000 0000000000000000
000002a100a67650 zfs:dmu_objset_create_sync+100 (30004eb8600, 2a1006216f0,
60010c6e448, 600103c7880, 60010bac200, 15)
  %l0-3: 0000000000000002 0000000000000002 000000007b303000 000000007b303400
  %l4-7: 0000060011399ce8 000002a100621800 0000000000000001 00000600117fea80
000002a100a67710 zfs:dsl_sync_task_group_sync+11c (600103cd5d8, 600103c7880,
7b28e730, 600115528d8, 3, 0)
  %l0-3: 0000000000014000 000000000003c000 0000000000050000 0000000000000000
  %l4-7: 00000600103cd600 0000060010fac140 000000007b28e570 0000000000000000
000002a100a677d0 zfs:dsl_pool_sync+ec (60010fac140, 7, 60010edd800, 7b309280,
600103c7880, 60010edd830)
  %l0-3: 0000000000000005 0000000000000000 0000030004e524c8 0000060010fac2c8
  %l4-7: 00000600116de2d8 0000000000000000 0000060010fac328 000000000128d800
000002a100a67880 zfs:spa_sync+208 (30004e520c0, 7, 0, 7b3090e0, 30004e52210,
7b309280)
  %l0-3: 0000030004e521b0 0000060010fac2f8 0000060010fac2c8 00000600101423c0
  %l4-7: 0000030004e52288 00000600110bd780 0000060010fac140 0000030004e52240
000002a100a67950 zfs:txg_sync_thread+248 (60010fac140, 7, 7b2fac0b, 5bad,
60010fac258, bb8)
  %l0-3: 0000060010fac2a0 0000060010fac2a6 0000060010fac2a4 00000000018d7e28
  %l4-7: 00000000700b4a64 0000000000000007 0000000000000003 000000007b30c6e0

Test machine: data16.sfbay
Core files:
/var/crash/data16/*.11

Test case zfs_create_005 causes system panic.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=2033


Grace <hua.tang at sun.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |major




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=2033





--- Comment #1 from Darren J Moffat <darrenm at opensolaris.org> 
2008-05-27 06:40:00 ---
After fixing the kernel panic I discovered that zfs_crypto_create()
wasn''t
returning failure when it failed to load the key.  This resulting in the wrong
failure message being returned to the user:

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=2033


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CAUSEKNOWN




--- Comment #2 from Darren J Moffat <darrenm at opensolaris.org> 
2008-05-27 06:41:05 ---
The user was presented with:

"cannot create ''tank/fs1'': parent
''tank'' is not a filesystem"

instead of:

"cannot create ''tank/fs1'': Failed to read key file: No
such file or directory"

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=2033


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CAUSEKNOWN                  |FIXINPROGRESS




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=2033


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|FIXINPROGRESS               |CLOSED
         Resolution|                            |FIXINSOURCE




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.