zfs crypto discuss - May 2008 - [Bug 1939] New: key validation causing panic.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1939

           Summary: key validation causing panic.
    Classification: Development
           Product: zfs-crypto
           Version: unspecified
          Platform: Other
        OS/Version: Solaris
            Status: NEW
          Severity: normal
          Priority: P2
         Component: other
        AssignedTo: darrenm at opensolaris.org
        ReportedBy: ajscarp at yahoo.com
         QAContact: hua.tang at sun.com
                CC: zfs-crypto-discuss at opensolaris.org
   Estimated Hours: 0.0


Using the latest bits in the gate.. I did a simple load/unload/load and
validation paniced..  

# zpool create -f tank c0t0d0s6
# zpool set keysource=raw,prompt tank
# cat /home/izick/key2 | zpool key -l tank
key1=0
outkey (909256)=31323334353637383930313233343531323334353637383930313233343573a
zic_key (909256)
salt= 0
keyscope= 0
keydata=31323334353637383930313233343531323334353637383930313233343573a
keysourcedataset name=tank
key2=3
key3=3
# zpool get keystatus tank
NAME  PROPERTY   VALUE        SOURCE
tank  keystatus  available    local
# zpool key -u tank
salt= 0
keyscope= 0
keydatakeysourcedataset name=tank
# cat /home/izick/key2 | zpool key -l tank
key
panic[cpu0]/thread=30003ad63c0: 1=2
assertion failed: nvlist_lookup_nvlist(nvl,
zpool_prop_to_name(ZPOOL_PROP_KEYCHECK), &nv) == 0, file:
../../common/fs/zfs/zio_crypt.c, line: 684

000002a100e5b490 genunix:assfail+78 (7b7bfb38, 7b7bf958, 2ac, 183ec00, 12b1400,
0)
  %l0-3: 000002a100e5b538 000000007bb5cc00 000000000000000c 0000000000000002
  %l4-7: 0000000000000002 0000000000000000 0000000001887c00 0000000000000000
000002a100e5b540 zfs:spa_crypto_key_validate+324 (600153e0fc0, 60013a4e000,
600150fb7b8, 7b7bf800, 25, 18)
  %l0-3: 0000000000000018 000000007b7bf800 000000007b7bf800 0000000000000030
  %l4-7: 0000000000000010 0000060011062e18 0000060013a4e000 00000000000ddfc8
000002a100e5b6a0 zfs:spa_crypto_key_load+50 (600153e0fc0, 600125e9020,
7b7b7a90, 0, 1, 0)
  %l0-3: 0000000000000001 00000600153e0fc0 0000030000528000 0000000000000000
  %l4-7: 0000000000000000 0000000000000000 0000000000000000 0000000000000001
000002a100e5b760 zfs:zfs_ioc_crypto+98 (600125e8000, 0, 7b7b7800, 0, b0, 0)
  %l0-3: 000000000189b1b8 0000000000000000 000000007b7b7800 0000000000000001
  %l4-7: 000000007b79fae8 000000007b79f800 0000000000001020 0000000000001000
000002a100e5b820 zfs:zfsdev_ioctl+17c (70085ba0, 70085ba8, ffbfa4b8, 1000,
600153432d0, 600125e8000)
  %l0-3: 0000000000000468 0000000070085800 000000000000008d 000000000000002f
  %l4-7: 00000000000000bc 0000000000000003 0000000070085bb0 000000007b79fb00
000002a100e5b8d0 genunix:fop_ioctl+58 (6001116fa40, 5a2f, ffbfa4b8, 100003, 0,
2a100e5badc)
  %l0-3: 0000060015e05a40 000000000139eda8 00000300003de300 0000000000000003
  %l4-7: 0000000000000000 0000000000000001 0000000000000000 00000000018be400
000002a100e5b990 genunix:ioctl+16c (3, 5a2f, ffbfa4b8, 0, 600161b3d20, 0)
  %l0-3: 0000000000000003 0000000000000003 000000001aca0000 0000000000001aca
  %l4-7: 0000000000000001 0000030000528000 0000000000000000 0000000000000000

panic: entering debugger (continue to save dump)

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1939


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|darrenm at opensolaris.org     |ajscarp at yahoo.com
             Status|NEW                         |ACCEPTED




--- Comment #1 from Darren J Moffat <darrenm at opensolaris.org> 
2008-05-19 12:50:28 ---
Assigning to Tony since he is investigating this just now.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1939


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |CLOSED
         Resolution|                            |FIXINSOURCE




--- Comment #2 from ajscarp at yahoo.com  2008-05-19 17:15:49 ---
Failure wad debugged to only happen in non-debug kernels..  Logic was running
out as to why this was happening given it worked fine for other properties and
for keycheck using debug kernels...  well logic was the problem here, there was
no in-depth problem hidden away in the depths of zfs crypto kernel code..  In
fact it was:

wait for it...

wait for it...

don''t get too anxious..

stay on target, gold leader..

here it was..

zap_update() in spa_sync_props() for unit8 arrays was inside an ASSERT3U
instead of a VERIFY3U.  Hence the zpool property was never updated in non-debug
kernels.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.