zfs crypto discuss - Apr 2008 - [Bug 1551] New: zpool import panic cross architecture

http://defect.opensolaris.org/bz/show_bug.cgi?id=1551

           Summary: zpool import panic cross architecture
    Classification: Development
           Product: zfs-crypto
           Version: unspecified
          Platform: Other
        OS/Version: Solaris
            Status: NEW
          Severity: critical
          Priority: P2
         Component: other
        AssignedTo: darrenm at opensolaris.org
        ReportedBy: hua.tang at sun.com
         QAContact: hua.tang at sun.com
                CC: zfs-crypto-discuss at opensolaris.org
   Estimated Hours: 0.0


On data16 (sparc):
# mkfile 1g /export/home/vdev_file
# zpool create -o keysource=hex,file://$HEX_KEY_FILE tank
/export/home/vdev_file
# zfs create -o encyrption=on tank/fs
# cp Hamlet.txt /tank/fs
# zpool export tank
# rcp /export/home/vdev_file stinger4p-3:/export/home

On stinger4p-3 (amd64):
# zpool import -d /export/home tank 

WARNING: zio_encrypt_data crypto_decrypt: c


panic[cpu1]/thread=ffffff0004f6fc80: assertion failed: dnp->dn_indblkshift
<17, file: ../../common/fs/zfs/dnode.c, line: 189

ffffff0004f6f990 genunix:assfail+7e ()
ffffff0004f6f9d0 zfs:dnode_byteswap+2d1 ()
ffffff0004f6fa10 zfs:dnode_buf_byteswap+3d ()
ffffff0004f6fa70 zfs:arc_read_done+10c ()
ffffff0004f6fab0 zfs:zio_done+5b ()
ffffff0004f6faf0 zfs:zio_execute+bb ()
ffffff0004f6fb50 zfs:zio_notify_parent+9b ()
ffffff0004f6fb90 zfs:zio_done+e7 ()
ffffff0004f6fbd0 zfs:zio_execute+bb ()
ffffff0004f6fc60 genunix:taskq_thread+1cb ()
ffffff0004f6fc70 unix:thread_start+8 ()

syncing file systems... done

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1551


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ACCEPTED




-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1551


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|zpool import panic cross    |data decryption cross
                   |architecture                |architecture fails in
                   |                            |AES_CCM
             Status|ACCEPTED                    |CAUSEKNOWN




--- Comment #1 from Darren J Moffat <darrenm at opensolaris.org> 
2008-06-03 08:59:52 ---
Since we are no longer encrypting the dnode I can''t reproduce the
panic.

However there is still a problem with cross architecture.

The AES CCM MAC for data isn''t verifying when moving a pool from sparc
to x86.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1551


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CAUSEKNOWN                  |CLOSED
         Resolution|                            |FIXED




--- Comment #2 from Darren J Moffat <darrenm at opensolaris.org> 
2008-06-09 07:09:25 ---
Needed to store the MAC in BE_64 just like is done for the checksum algorithms.

Note that this bug fix also switched where we put the MAC it is now in the high
two words where previously it was in the low two words.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.