zfs crypto discuss - Apr 2008 - [Bug 1080] New: no error message displayed for ''zfs create -o encryption= on -o keyscope=dataset pool/fs''

http://defect.opensolaris.org/bz/show_bug.cgi?id=1080

           Summary: no error message displayed for ''zfs create -o
                    encryption=on -o keyscope=dataset pool/fs''
    Classification: Development
           Product: zfs-crypto
           Version: unspecified
          Platform: Other
        OS/Version: Solaris
            Status: NEW
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: darrenm at opensolaris.org
        ReportedBy: hua.tang at sun.com
         QAContact: hua.tang at sun.com
                CC: zfs-crypto-discuss at opensolaris.org
   Estimated Hours: 0.0


Without ''-o keysource=..'', this subcommand should fail.
Currently it fails
without any prompt. Error messages should be displayed to indicate the failure.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1080


Darren J Moffat <darrenm at opensolaris.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |INCOMPLETE




--- Comment #1 from Darren J Moffat <darrenm at opensolaris.org> 
2008-04-10 02:00:13 ---
An explicit keysource= is not required since it could be inherited from the
parent dataset (which may not even have encryption turned on).  It can not
however be inherited from the pool property of the same name.

I''m marking this incomplete since I don''t know what the
keysource value on the
parent dataset was in this case.   If it wasn''t set then there is
indeed a bug
here and there should be an error message and a failure since we have no key
material to create a keyscope=dataset filesystem.

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1080





--- Comment #2 from Grace <hua.tang at sun.com>  2008-04-10 19:02:11 ---
In the test case, the parent dataset is the pool level dataset.

# zpool create tank /export/home/testfile
# zfs create -o encryption=on -o keyscope=dataset tank/fs
# echo $?
1
# zfs list
NAME   USED  AVAIL  REFER  MOUNTPOINT
tank    88K   984M     1K  /tank
#

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1080





--- Comment #3 from ajscarp at yahoo.com  2008-04-14 09:10:47 ---
This would seem to be a duplicate of 1114

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=1080


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|darrenm at opensolaris.org     |ajscarp at yahoo.com
             Status|INCOMPLETE                  |CLOSED
         Resolution|                            |FIXINSOURCE




--- Comment #4 from ajscarp at yahoo.com  2008-04-20 09:11:27 ---
i think this was fixed in the source, but missed build 2008-4-10

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.