zfs crypto discuss - Mar 2008 - [Bug 668] New: libzfs:load_key() probably should allow null values for zfs_crypt_t

http://defect.opensolaris.org/bz/show_bug.cgi?id=668

           Summary: libzfs:load_key() probably should allow null values for
                    zfs_crypt_t
    Classification: Development
           Product: zfs-crypto
           Version: unspecified
          Platform: Other
        OS/Version: Solaris
            Status: NEW
          Severity: minor
          Priority: P4
         Component: other
        AssignedTo: ajscarp at yahoo.com
        ReportedBy: ajscarp at yahoo.com
         QAContact: hua.tang at sun.com
                CC: zfs-crypto-discuss at opensolaris.org
   Estimated Hours: 0.0


During the most recent merger on Feb 29th, a change by Darren allowed load_key
to accept a NULL value for the zfs_crypt_t argument.  However a change done by
me required further dependence a structure being passed because of the addition
of the random salt and optimizations done in load_key..  In the interest of
getting new code put back, I changed it to disallow nulls.

Having a null value allowed might be a reasonable though.  zpool_load_key
callers shouldn''t have to send a zero''ed zfs_crypt_t
structure, only when the
caller actually provides data.

It could easily be changed to accept null and then have the function create
structure for internal use..

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://defect.opensolaris.org/bz/show_bug.cgi?id=668


ajscarp at yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from ajscarp at yahoo.com  2008-03-07 20:29:16 ---
issue resolved, but will further disappear with zfs_crypt_t getting moved into
libzfs_handle_t

-- 
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.