Hi. The zfs rollback seems to be broken in recent ZFS. The problem is that z_mode is set too early - before sa_bulk_lookup() call, so ''mode'' variable is uninitialized. The patch below fixes the problem for me: http://people.freebsd.org/~pjd/patches/zfs_znode.c.4.patch -- Pawel Jakub Dawidek http://www.wheelsystems.com pjd at FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 196 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/zfs-code/attachments/20100613/7d5feae8/attachment.bin>
On 6/13/10 2:01 PM, Pawel Jakub Dawidek wrote:> Hi. > > The zfs rollback seems to be broken in recent ZFS. The problem is that > z_mode is set too early - before sa_bulk_lookup() call, so ''mode'' > variable is uninitialized. > > The patch below fixes the problem for me: > > http://people.freebsd.org/~pjd/patches/zfs_znode.c.4.patch >Thanks, I''ve opened bug: 6960907 zfs_rezget() has uninitialized z_mode variable
Pawel, Great find -- thank you! Jeff On Jun 13, 2010, at 1:01 PM, Pawel Jakub Dawidek wrote:> Hi. > > The zfs rollback seems to be broken in recent ZFS. The problem is that > z_mode is set too early - before sa_bulk_lookup() call, so ''mode'' > variable is uninitialized. > > The patch below fixes the problem for me: > > http://people.freebsd.org/~pjd/patches/zfs_znode.c.4.patch > > -- > Pawel Jakub Dawidek http://www.wheelsystems.com > pjd at FreeBSD.org http://www.FreeBSD.org > FreeBSD committer Am I Evil? Yes, I Am! > _______________________________________________ > zfs-code mailing list > zfs-code at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/zfs-code