zfs code - Jan 2010 - [PATCH] ddt_phys_type_t should be typedef

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

While working on updating the ZFS port for FreeBSD, I found that we have:

%%%
enum ddt_phys_type {
	DDT_PHYS_DITTO = 0,
	DDT_PHYS_SINGLE = 1,
	DDT_PHYS_DOUBLE = 2,
	DDT_PHYS_TRIPLE = 3,
	DDT_PHYS_TYPES
} ddt_phys_type_t;
%%%

Which will create an instance for enum ddt_phys_type, while what we
really want should be a typedef.  Patch is attached.

Cheers,
- -- 
Xin LI <delphij at delphij.net>	http://www.delphij.net/
FreeBSD - The Power to Serve!	       Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iQEcBAEBAgAGBQJLWNKxAAoJEATO+BI/yjfBqJwIAJCkcSnqTFjrlnQgryhNTc1s
FrFyXjMNOLNnwhKZZU26msIibceAxz0QhVxbyvfogqg4LIHpHSI7ln+NnhMcaVVM
uj54k6/Y2GzrVUCHUdIa4LTi3OLZBqpJU+rVK1GsnydmesNJC2ZKVrQCu78DmbJw
C5q4xfD3n8q4ZfESHEHwWIlJeku7oGgJBQ35Y/AVk042/4JK7D4YI81bnOrFYZ62
U5p3BnfpL4kJzPbRTwV7udH0fpZimoUNxGo8bfv6LG9U/v5a10XxhaqamOJI15KH
+eAJEksWEnyJYgnZw9VUZAusGuvKOXPNJLPXWLJA3qqgHVqLHhs/d5Wqi/L10no=XjCs
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ddt.h.diff
URL:
<http://mail.opensolaris.org/pipermail/zfs-code/attachments/20100121/42da4f67/attachment.ksh>

Thank you for this. We''ll get it integrated.

Adam

On Jan 21, 2010, at 2:18 PM, Xin LI wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi,
> 
> While working on updating the ZFS port for FreeBSD, I found that we have:
> 
> %%%
> enum ddt_phys_type {
> 	DDT_PHYS_DITTO = 0,
> 	DDT_PHYS_SINGLE = 1,
> 	DDT_PHYS_DOUBLE = 2,
> 	DDT_PHYS_TRIPLE = 3,
> 	DDT_PHYS_TYPES
> } ddt_phys_type_t;
> %%%
> 
> Which will create an instance for enum ddt_phys_type, while what we
> really want should be a typedef.  Patch is attached.
> 
> Cheers,
> - -- 
> Xin LI <delphij at delphij.net>	http://www.delphij.net/
> FreeBSD - The Power to Serve!	       Live free or die
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.14 (FreeBSD)
> 
> iQEcBAEBAgAGBQJLWNKxAAoJEATO+BI/yjfBqJwIAJCkcSnqTFjrlnQgryhNTc1s
> FrFyXjMNOLNnwhKZZU26msIibceAxz0QhVxbyvfogqg4LIHpHSI7ln+NnhMcaVVM
> uj54k6/Y2GzrVUCHUdIa4LTi3OLZBqpJU+rVK1GsnydmesNJC2ZKVrQCu78DmbJw
> C5q4xfD3n8q4ZfESHEHwWIlJeku7oGgJBQ35Y/AVk042/4JK7D4YI81bnOrFYZ62
> U5p3BnfpL4kJzPbRTwV7udH0fpZimoUNxGo8bfv6LG9U/v5a10XxhaqamOJI15KH
> +eAJEksWEnyJYgnZw9VUZAusGuvKOXPNJLPXWLJA3qqgHVqLHhs/d5Wqi/L10no> =XjCs
> -----END PGP SIGNATURE-----
> <ddt.h.diff>_______________________________________________
> zfs-code mailing list
> zfs-code at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/zfs-code

--
Adam Leventhal, Fishworks                        http://blogs.sun.com/ahl