Xen devel - Dec 2013 - xen installing dmesg executable in /usr/local/bin potentially overriding the system dmesg

Hi,


At present xen seems to be installing a "dmesg" executable tool to my
/usr/local/bin, which seems to
nicely override the normal dmesg with some sort of integrated "xl
dmesg" version.

Doesn''t seem like the intention these ocaml tests are installed ?

From the tree:
/usr/src/new/xen-unstable-vanilla/dist/install/usr/local/bin/dmesg
/usr/src/new/xen-unstable-vanilla/tools/ocaml/test/dmesg
/usr/src/new/xen-unstable-vanilla/tools/ocaml/test/dmesg.annot
/usr/src/new/xen-unstable-vanilla/tools/ocaml/test/dmesg.cmi
/usr/src/new/xen-unstable-vanilla/tools/ocaml/test/dmesg.cmx
/usr/src/new/xen-unstable-vanilla/tools/ocaml/test/dmesg.ml
/usr/src/new/xen-unstable-vanilla/tools/ocaml/test/dmesg.o
/usr/src/new/xen-unstable-vanilla/tools/xm-test/tests/dmesg
/usr/src/new/xen-unstable-vanilla/tools/xm-test/tests/dmesg/01_dmesg_basic_pos.py
/usr/src/new/xen-unstable-vanilla/tools/xm-test/tests/dmesg/02_dmesg_basic_neg.py
/usr/src/new/xen-unstable-vanilla/tools/xm-test/tests/dmesg/Makefile.am

--
Sander

On Wed, 2013-12-11 at 23:43 +0100, Sander Eikelenboom
wrote:
> Hi,
> 
> 
> At present xen seems to be installing a "dmesg" executable tool
to my /usr/local/bin, which seems to
> nicely override the normal dmesg with some sort of integrated "xl
dmesg" version.
> 
> Doesn''t seem like the intention these ocaml tests are installed ?
I don''t think so either. 

None of these should be installed:
        dist/install/usr/local/bin/dmesg
        dist/install/usr/local/bin/list_domains
        dist/install/usr/local/bin/raise_exception
        dist/install/usr/local/bin/send_debug_keys
        dist/install/usr/local/bin/xtl
(but dmesg is clearly the worse one)

Rob, can you put together a patch ASAP please.

Thanks,
Ian.

Ian Campbell wrote:
> On Wed, 2013-12-11 at 23:43 +0100, Sander Eikelenboom wrote:
> > Hi,
> >
> >
> > At present xen seems to be installing a "dmesg" executable
tool to my
> > /usr/local/bin, which seems to nicely override the normal dmesg with
> some sort of integrated "xl dmesg" version.
> >
> > Doesn''t seem like the intention these ocaml tests are
installed ?
> 
> I don''t think so either.
> 
> None of these should be installed:
>         dist/install/usr/local/bin/dmesg
>         dist/install/usr/local/bin/list_domains
>         dist/install/usr/local/bin/raise_exception
>         dist/install/usr/local/bin/send_debug_keys
>         dist/install/usr/local/bin/xtl
> (but dmesg is clearly the worse one)
> 
> Rob, can you put together a patch ASAP please.
Yes, the install section in tools/ocaml/test/Makefile needs to go away.
I''ll send a patch.

Cheers,
Rob