Xen devel - Nov 2013 - Re: [edk2] [PATCH v4 1/7] MdeModulePkg: introduce PcdPciDisableBusEnumeration

On Fri, Nov 29, 2013 at 6:13 AM, Wei Liu <wei.liu2@citrix.com>
wrote:
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c
b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c
> index 5afbb82..cc6be8b 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c
> @@ -284,7 +284,10 @@ PciBusDriverBindingStart (
>            );
>    }
>
> -  gFullEnumeration = (BOOLEAN) ((SearchHostBridgeHandle (Controller) ?
FALSE : TRUE));
> +  if (PcdGetBool (PcdPciDisableBusEnumeration))
> +    gFullEnumeration = FALSE;
> +  else
> +    gFullEnumeration = (BOOLEAN) ((SearchHostBridgeHandle (Controller) ?
FALSE : TRUE));
Code style { }

I think this could be fixed at commit time.
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
> index b627eb1..5198451 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -878,6 +878,9 @@
>    ## This PCD specified whether the S.M.A.R.T feature of attached ATA hard
disks are enabled.
>    gEfiMdeModulePkgTokenSpaceGuid.PcdAtaSmartEnable|TRUE|BOOLEAN|0x00010065
>
> +  ## This PCD specifies whether full PCI enumeration is disabled.
> + 
gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|FALSE|BOOLEAN|0x10000048
Mike,

Any preference on token number other than don''t clash?

Do you give your Reviewed-by for this patch? If so, I could take care
of committing it.

-Jordan