Jingoo Han
2013-Nov-28 03:48 UTC
[PATCH] xen: platform-pci: use DEFINE_PCI_DEVICE_TABLE macro
This macro is used to create a struct pci_device_id array.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/xen/platform-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c
index 2f3528e..7ab5e81 100644
--- a/drivers/xen/platform-pci.c
+++ b/drivers/xen/platform-pci.c
@@ -170,7 +170,7 @@ pci_out:
return ret;
}
-static struct pci_device_id platform_pci_tbl[] = {
+static DEFINE_PCI_DEVICE_TABLE(platform_pci_tbl) = {
{PCI_VENDOR_ID_XEN, PCI_DEVICE_ID_XEN_PLATFORM,
PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{0,}
--
1.7.10.4
Jingoo Han
2013-Nov-28 04:41 UTC
Re: [PATCH] xen: platform-pci: use DEFINE_PCI_DEVICE_TABLE macro
On Thursday, November 28, 2013 12:48 PM, Jingoo Han wrote:> > This macro is used to create a struct pci_device_id array. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com>Please, ignore this patch. According to the Greg Kroah-Hartman, "Yeah, and it''s a horrid macro that deserves to be removed, please don''t use it in more places. Actually, if you could just remove it, that would be best, sorry, I''m not going to take these patches." So, I will send the patch to remove ''DEFINE_PCI_DEVICE_TABLE'' instead. Sorry for annoying. :-) Best regards, Jingoo Han> --- > drivers/xen/platform-pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c > index 2f3528e..7ab5e81 100644 > --- a/drivers/xen/platform-pci.c > +++ b/drivers/xen/platform-pci.c > @@ -170,7 +170,7 @@ pci_out: > return ret; > } > > -static struct pci_device_id platform_pci_tbl[] = { > +static DEFINE_PCI_DEVICE_TABLE(platform_pci_tbl) = { > {PCI_VENDOR_ID_XEN, PCI_DEVICE_ID_XEN_PLATFORM, > PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, > {0,} > -- > 1.7.10.4