Laszlo Ersek
2013-Nov-26 13:57 UTC
Re: [edk2] [PATCH RFC v2 7/7] OvmfPkg: introduce XenMemMapInitialization
On 11/26/13 14:46, Wei Liu wrote:> On Mon, Nov 25, 2013 at 12:38:04PM -0800, Jordan Justen wrote: >> Regarding patches 5-7, it seems like the mem-map code flow could be >> more shared. It is a bit challenging to unravel things though. >> > > Indeed. It''s a bit unfortunate that this path is shared by all users of > OVMF. And from a previous email on edk2-devel I can see that QEMU / KVM > is also trying to deal with this now with different approach -- > modifying MemMapInitialization -- that would not work with Xen. > > (What is interesting is that QEMU_PEI_INFO is very similar to what I > proposed for Xen in my RFC email. ;-) ) > > I cannot come up with a sensible solution for all platforms, so it makes > sense for me to keep and maintain a separate path, given that the path > is relatively short and straightforward.I agree. Let''s try to fix the memmap in PEI for Xen and Qemu independently, and then we can extract the common bits. Hopefully. (I''m putting the qemu part aside for now because we''re obviously not converging on how to fix that.) Thanks Laszlo