Xen devel - Nov 2013 - Re: [edk2] [PATCH RFC v2 3/7] OvmfPkg: define EFI_XEN_OVMF_INFO and extend XenInfo

On Sun, 2013-11-24 at 17:46 -0800, Jordan Justen wrote:
> > +#pragma pack(1)
> > +typedef struct {
> > +  CHAR8 Signature[11]; /* XenHVMOVMF\0 */
> > +  CHAR8 Padding[3];
> 
> Does this follow a convention used by Xen? Normally EDK II would use
> either a 4 or 8 byte integer signature with SIGNATURE_32/64.
> 
> This information does not seem all that OVMF specific, but I guess
> from Xen''s perspective it is?
I think it''s actually pretty similar to what we currently pass to
SeaBIOS but I don''t think we would want to force ourselves to co-evolve
all three of those together, we can still take advantage of some common
code on the Xen side without tying the actual interfaces together.

You can see the SeaBIOS side in Xen at
http://xenbits.xen.org/gitweb/?p=xen.git;a=blob;f=tools/firmware/hvmloader/seabios.c;h=dd7dfbe0e8a571e2239a1753d38fa0d1b8f0b5c7;hb=HEAD#l37
> Since this struct defines a Xen <=> OVMF data transfer, maybe we
> should consider a new include file? Or, maybe just a good comment on
> the structure?
FWIW It Xen=>OVMF only, not bidirectional.

Ian,