Stefano Stabellini
2013-Nov-15 11:57 UTC
[PATCH v2] swiotlb-xen: add missing xen_dma_map_page call
swiotlb-xen is missing a xen_dma_map_page call in xen_swiotlb_map_sg_attrs, in the bounce buffer path. Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Changes in v2: - reworked commit message. --- drivers/xen/swiotlb-xen.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index a224bc7..1eac073 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -555,6 +555,11 @@ xen_swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl, sg_dma_len(sgl) = 0; return 0; } + xen_dma_map_page(hwdev, pfn_to_page(map >> PAGE_SHIFT), + map & ~PAGE_MASK, + sg->length, + dir, + attrs); sg->dma_address = xen_phys_to_bus(map); } else { /* we are not interested in the dma_addr returned by -- 1.7.2.5
Konrad Rzeszutek Wilk
2013-Nov-15 14:15 UTC
Re: [PATCH v2] swiotlb-xen: add missing xen_dma_map_page call
On Fri, Nov 15, 2013 at 11:57:33AM +0000, Stefano Stabellini wrote:> swiotlb-xen is missing a xen_dma_map_page call in > xen_swiotlb_map_sg_attrs, in the bounce buffer path. > > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> >Thank you! Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>> Changes in v2: > - reworked commit message. > --- > drivers/xen/swiotlb-xen.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c > index a224bc7..1eac073 100644 > --- a/drivers/xen/swiotlb-xen.c > +++ b/drivers/xen/swiotlb-xen.c > @@ -555,6 +555,11 @@ xen_swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl, > sg_dma_len(sgl) = 0; > return 0; > } > + xen_dma_map_page(hwdev, pfn_to_page(map >> PAGE_SHIFT), > + map & ~PAGE_MASK, > + sg->length, > + dir, > + attrs); > sg->dma_address = xen_phys_to_bus(map); > } else { > /* we are not interested in the dma_addr returned by > -- > 1.7.2.5 >