Jeff Liu
2013-Nov-13 12:59 UTC
[PATCH v2] xen: simplify balloon_first_page() with list_first_entry_or_null()
From: Jie Liu <jeff.liu@oracle.com>
Replace the code logic at balloon_first_page() by calling
list_first_entry_or_null() directly. since here is only
one user of that routine, therefore we can just remove it.
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
v2: remove balloon_first_page() with this change.
drivers/xen/balloon.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 55ea73f..16ffe91 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -157,13 +157,6 @@ static struct page *balloon_retrieve(bool prefer_highmem)
return page;
}
-static struct page *balloon_first_page(void)
-{
- if (list_empty(&ballooned_pages))
- return NULL;
- return list_entry(ballooned_pages.next, struct page, lru);
-}
-
static struct page *balloon_next_page(struct page *page)
{
struct list_head *next = page->lru.next;
@@ -328,7 +321,7 @@ static enum bp_state increase_reservation(unsigned long
nr_pages)
if (nr_pages > ARRAY_SIZE(frame_list))
nr_pages = ARRAY_SIZE(frame_list);
- page = balloon_first_page();
+ page = list_first_entry_or_null(&ballooned_pages, struct page, lru);
for (i = 0; i < nr_pages; i++) {
if (!page) {
nr_pages = i;
--
1.8.3.2
David Vrabel
2013-Nov-13 14:03 UTC
Re: [PATCH v2] xen: simplify balloon_first_page() with list_first_entry_or_null()
On 13/11/13 12:59, Jeff Liu wrote:> From: Jie Liu <jeff.liu@oracle.com> > > Replace the code logic at balloon_first_page() by calling > list_first_entry_or_null() directly. since here is only > one user of that routine, therefore we can just remove it. > > Signed-off-by: Jie Liu <jeff.liu@oracle.com>Reviewed-by: David Vrabel <david.vrabel@citrix.com> (In case anyone else is wondering this list function was introduced in 3.10.) David