Matthew Daley
2013-Oct-31 05:49 UTC
[PATCH] xencommons: write domain 0''s domid to xenstore
libvchan''s init_xs_srv (server-side xenstore-related initialization)
expects to find the current domain''s domid at this xenstore key. libxl
(and xend) write this for domains they create. Do the same for domain 0,
allowing the use of libvchan in dom0.
Signed-off-by: Matthew Daley <mattjd@gmail.com>
---
tools/hotplug/Linux/init.d/xencommons | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/hotplug/Linux/init.d/xencommons
b/tools/hotplug/Linux/init.d/xencommons
index a2e633b..4ebd636 100644
--- a/tools/hotplug/Linux/init.d/xencommons
+++ b/tools/hotplug/Linux/init.d/xencommons
@@ -108,8 +108,9 @@ do_start () {
exit 1
fi
- echo Setting domain 0 name...
+ echo Setting domain 0 name and domid...
${BINDIR}/xenstore-write "/local/domain/0/name"
"Domain-0"
+ ${BINDIR}/xenstore-write "/local/domain/0/domid" 0
fi
echo Starting xenconsoled...
--
1.7.10.4
Matthew Daley
2013-Oct-31 06:03 UTC
[PATCH v2] xencommons: write domain 0''s domid to xenstore
libvchan''s init_xs_srv (server-side xenstore-related initialization)
expects to find the current domain''s domid at this xenstore key. libxl
(and xend) write this for domains they create. Do the same for domain 0,
allowing the use of libvchan in dom0.
Signed-off-by: Matthew Daley <mattjd@gmail.com>
---
v2: Modify NetBSD xencommons too.
tools/hotplug/Linux/init.d/xencommons | 3 ++-
tools/hotplug/NetBSD/rc.d/xencommons | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/hotplug/Linux/init.d/xencommons
b/tools/hotplug/Linux/init.d/xencommons
index a2e633b..4ebd636 100644
--- a/tools/hotplug/Linux/init.d/xencommons
+++ b/tools/hotplug/Linux/init.d/xencommons
@@ -108,8 +108,9 @@ do_start () {
exit 1
fi
- echo Setting domain 0 name...
+ echo Setting domain 0 name and domid...
${BINDIR}/xenstore-write "/local/domain/0/name"
"Domain-0"
+ ${BINDIR}/xenstore-write "/local/domain/0/domid" 0
fi
echo Starting xenconsoled...
diff --git a/tools/hotplug/NetBSD/rc.d/xencommons
b/tools/hotplug/NetBSD/rc.d/xencommons
index fe4c9ac..b1c3531 100644
--- a/tools/hotplug/NetBSD/rc.d/xencommons
+++ b/tools/hotplug/NetBSD/rc.d/xencommons
@@ -68,8 +68,9 @@ xen_startcmd()
printf "\n"
- printf "Setting domain 0 name.\n"
+ printf "Setting domain 0 name and domid.\n"
${BINDIR}/xenstore-write "/local/domain/0/name" "Domain-0"
+ ${BINDIR}/xenstore-write "/local/domain/0/domid" 0
}
xen_stop()
--
1.7.10.4
Roger Pau Monné
2013-Oct-31 08:51 UTC
Re: [PATCH v2] xencommons: write domain 0''s domid to xenstore
On 31/10/13 07:03, Matthew Daley wrote:> libvchan''s init_xs_srv (server-side xenstore-related initialization) > expects to find the current domain''s domid at this xenstore key. libxl > (and xend) write this for domains they create. Do the same for domain 0, > allowing the use of libvchan in dom0. > > Signed-off-by: Matthew Daley <mattjd@gmail.com>I also have a patch similar to this one in my driver domain series: http://marc.info/?l=xen-devel&m=138070596009369 Which also adds a function to get the domid from libxl. I''m happy for this to go in before mine: Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Ian Campbell
2013-Oct-31 22:05 UTC
Re: [PATCH v2] xencommons: write domain 0''s domid to xenstore
On Thu, 2013-10-31 at 09:51 +0100, Roger Pau Monné wrote:> On 31/10/13 07:03, Matthew Daley wrote: > > libvchan''s init_xs_srv (server-side xenstore-related initialization) > > expects to find the current domain''s domid at this xenstore key. libxl > > (and xend) write this for domains they create. Do the same for domain 0, > > allowing the use of libvchan in dom0. > > > > Signed-off-by: Matthew Daley <mattjd@gmail.com> > > I also have a patch similar to this one in my driver domain series: > > http://marc.info/?l=xen-devel&m=138070596009369 > > Which also adds a function to get the domid from libxl. I''m happy for > this to go in before mine: > > Acked-by: Roger Pau Monné <roger.pau@citrix.com>Thanks both of you. Acked also and applied.