Xen devel - Oct 2013 - [PATCH] xen/arm: Add EARLY_PRINT support for Broadcom brcm platform.

Enable early print support for the Broadcom A15 platform, brcm.

Signed-off-by: Jon Fraser <jfraser@broadcom.com>
---
 xen/arch/arm/Rules.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
index bd79b26..c27c2eb 100644
--- a/xen/arch/arm/Rules.mk
+++ b/xen/arch/arm/Rules.mk
@@ -77,6 +77,11 @@ EARLY_PRINTK_INC := 8250
 EARLY_UART_BASE_ADDRESS := 0x01c28000
 EARLY_UART_REG_SHIFT := 2
 endif
+ifeq ($(CONFIG_EARLY_PRINTK), brcm)
+EARLY_PRINTK_INC := 8250
+EARLY_UART_BASE_ADDRESS := 0xF0406B00
+EARLY_UART_REG_SHIFT := 2
+endif
 
 ifneq ($(EARLY_PRINTK_INC),)
 EARLY_PRINTK := y
-- 
1.7.11.3

On Mon, 2013-10-28 at 21:50 -0400, Jon Fraser wrote:
> Enable early print support for the Broadcom A15 platform, brcm.
> 
> Signed-off-by: Jon Fraser <jfraser@broadcom.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>

I suppose this relies on your other patch to handle UARTs which are
offset into the page to be functional but it is harmless (at least to !
brcm) platforms until then?
> ---
>  xen/arch/arm/Rules.mk | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> index bd79b26..c27c2eb 100644
> --- a/xen/arch/arm/Rules.mk
> +++ b/xen/arch/arm/Rules.mk
> @@ -77,6 +77,11 @@ EARLY_PRINTK_INC := 8250
>  EARLY_UART_BASE_ADDRESS := 0x01c28000
>  EARLY_UART_REG_SHIFT := 2
>  endif
> +ifeq ($(CONFIG_EARLY_PRINTK), brcm)
> +EARLY_PRINTK_INC := 8250
> +EARLY_UART_BASE_ADDRESS := 0xF0406B00
> +EARLY_UART_REG_SHIFT := 2
> +endif
>  
>  ifneq ($(EARLY_PRINTK_INC),)
>  EARLY_PRINTK := y

Yes, it''s harmless to the other platforms.  Verified with test builds.

Jon

On Thu, 2013-10-31 at 15:07 +0000, Ian Campbell wrote:
> On Mon, 2013-10-28 at 21:50 -0400, Jon Fraser wrote:
> > Enable early print support for the Broadcom A15 platform, brcm.
> > 
> > Signed-off-by: Jon Fraser <jfraser@broadcom.com>
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> I suppose this relies on your other patch to handle UARTs which are
> offset into the page to be functional but it is harmless (at least to !
> brcm) platforms until then?
> 
> > ---
> >  xen/arch/arm/Rules.mk | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> > index bd79b26..c27c2eb 100644
> > --- a/xen/arch/arm/Rules.mk
> > +++ b/xen/arch/arm/Rules.mk
> > @@ -77,6 +77,11 @@ EARLY_PRINTK_INC := 8250
> >  EARLY_UART_BASE_ADDRESS := 0x01c28000
> >  EARLY_UART_REG_SHIFT := 2
> >  endif
> > +ifeq ($(CONFIG_EARLY_PRINTK), brcm)
> > +EARLY_PRINTK_INC := 8250
> > +EARLY_UART_BASE_ADDRESS := 0xF0406B00
> > +EARLY_UART_REG_SHIFT := 2
> > +endif
> >  
> >  ifneq ($(EARLY_PRINTK_INC),)
> >  EARLY_PRINTK := y
> 
> 
>

On Thu, 2013-10-31 at 15:39 -0400, Jon Fraser wrote:
> Yes, it''s harmless to the other platforms.  Verified with test
builds.
Applied, thanks.