Ian Jackson
2013-Oct-11 17:28 UTC
Re: [osstest test] 19795: tolerable trouble: broken/fail/pass - PUSHED
Ian Campbell writes ("Re: [osstest test] 19795: tolerable trouble: broken/fail/pass - PUSHED"):> On Wed, 2013-09-25 at 09:07 +0100, xen.org wrote:...> /tftpboot/pxe//0A50E56D/pxelinux--osstest.cfg No such file or directory at Osstest/TestSupport.pm line 916. > > And indeed this doesn''t exist. The answer appears to be: > $ ./mg-hosts mkpxedir marilith-n5 > Undefined subroutine &main::selecthost called at ./mg-hosts line 42.Yes.> Adding use TestSupport; fixes that, but I didn''t commit -- it seems like > in eefa3a09e48f "wip reorg move things into TestSupport" you might have > intended something else? In any case: > > $ ./mg-hosts mkpxedir marilith-n5 > Use of uninitialized value $otherflightjob in pattern match (m//) at Osstest/TestSupport.pm line 267. > Use of uninitialized value $otherflightjob in pattern match (m//) at Osstest/TestSupport.pm line 267. > Use of uninitialized value $otherflightjob in concatenation (.) or string at Osstest/TestSupport.pm line 267. > ? at Osstest/TestSupport.pm line 267....> I eventually just hacked it with: > --- a/mg-hosts > +++ b/mg-hosts > @@ -39,7 +39,9 @@ sub l ($) { return split /,/, $_[0]; } > sub cmd_mkpxedir () { > die unless @ARGV>=1; > foreach my $hn (@ARGV) { > - my $ho= selecthost("host=$hn"); > + #my $ho= selecthost("host=$hn"); > + die unless $hn eq "marilith-n5"; > + my $ho= { Ether => "fc:2f:40:dd:a8:4c" };Perhaps the right answer is to make selecthost''s setting of Suite conditional on $job being defined. I think mg-* scripts are allowed to "use TestSupport;".> Then: > $ ./mg-hosts mkpxedir marilith-n5 > chown: cannot access `fc-2f-40-dd-a8-4c'': No such file or directory > set -e > cd /tftpboot/pxe// > sudo chown root.osstest fc-2f-40-dd-a8-4c > sudo chmod 2775 fc-2f-40-dd-a8-4c > sudo rm -f marilith-n5 > sudo ln -s fc-2f-40-dd-a8-4c marilith-n5 > ls -ald marilith-n5 fc-2f-40-dd-a8-4c > : 256 at Osstest.pm line 275. > > At which point I manually mkdir''d fc-2f-40-dd-a8-4c and: > $ ./mg-hosts mkpxedir marilith-n5 > drwxrwsr-x 2 root osstest 4096 Sep 25 10:00 fc-2f-40-dd-a8-4c > lrwxrwxrwx 1 root root 17 Sep 25 10:00 marilith-n5 -> fc-2f-40-dd-a8-4cI think mkpxedir needs to have a mkdir (perhaps a mkdir -p) in it. Ian.