Obviously we need a %s here.
Signed-off-by: Zhu Yanhai <gaoyang.zyh@taobao.com>
---
tools/xm-test/lib/XmTestLib/Console.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/xm-test/lib/XmTestLib/Console.py
b/tools/xm-test/lib/XmTestLib/Console.py
index b92f32b..e05cf0d 100755
--- a/tools/xm-test/lib/XmTestLib/Console.py
+++ b/tools/xm-test/lib/XmTestLib/Console.py
@@ -291,7 +291,7 @@ if __name__ == "__main__":
try:
run = t.runCmd(sys.argv[2])
except ConsoleError, e:
- print "Console failed (%)" % str(e)
+ print "Console failed (%s)" % str(e)
sys.exit(255)
t._XmConsole__closeConsole()
--
1.7.4.4
On Mon, 2013-09-23 at 18:02 +0800, Zhu Yanhai wrote:> Obviously we need a %s here.Yes, thanks. Are you actually running xm-test? I wasn''t aware that it still even worked...> > Signed-off-by: Zhu Yanhai <gaoyang.zyh@taobao.com> > --- > tools/xm-test/lib/XmTestLib/Console.py | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/xm-test/lib/XmTestLib/Console.py b/tools/xm-test/lib/XmTestLib/Console.py > index b92f32b..e05cf0d 100755 > --- a/tools/xm-test/lib/XmTestLib/Console.py > +++ b/tools/xm-test/lib/XmTestLib/Console.py > @@ -291,7 +291,7 @@ if __name__ == "__main__": > try: > run = t.runCmd(sys.argv[2]) > except ConsoleError, e: > - print "Console failed (%)" % str(e) > + print "Console failed (%s)" % str(e) > sys.exit(255) > > t._XmConsole__closeConsole()
2013/9/23 Ian Campbell <Ian.Campbell@citrix.com>:> On Mon, 2013-09-23 at 18:02 +0800, Zhu Yanhai wrote: >> Obviously we need a %s here. > > Yes, thanks. > > Are you actually running xm-test? I wasn''t aware that it still even > worked...Just trying to make it work with a modern CentOS HVM image, since we are porting the xen patches to a vendor kernel and I need some testsuite to make sure the Dom0 functions are working as expected. I think I have no other choice but xm-test - or at least its infrastructure can be reused. -- Thanks, Zhu Yanhai> >> >> Signed-off-by: Zhu Yanhai <gaoyang.zyh@taobao.com> >> --- >> tools/xm-test/lib/XmTestLib/Console.py | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/tools/xm-test/lib/XmTestLib/Console.py b/tools/xm-test/lib/XmTestLib/Console.py >> index b92f32b..e05cf0d 100755 >> --- a/tools/xm-test/lib/XmTestLib/Console.py >> +++ b/tools/xm-test/lib/XmTestLib/Console.py >> @@ -291,7 +291,7 @@ if __name__ == "__main__": >> try: >> run = t.runCmd(sys.argv[2]) >> except ConsoleError, e: >> - print "Console failed (%)" % str(e) >> + print "Console failed (%s)" % str(e) >> sys.exit(255) >> >> t._XmConsole__closeConsole() > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel
On Wed, 2013-09-25 at 10:41 +0800, Zhu Yanhai wrote:> 2013/9/23 Ian Campbell <Ian.Campbell@citrix.com>: > > On Mon, 2013-09-23 at 18:02 +0800, Zhu Yanhai wrote: > >> Obviously we need a %s here. > > > > Yes, thanks. > > > > Are you actually running xm-test? I wasn''t aware that it still even > > worked... > > Just trying to make it work with a modern CentOS HVM image, since we are > porting the xen patches to a vendor kernel and I need some testsuite to > make sure the Dom0 functions are working as expected. I think I have no > other choice but xm-test - or at least its infrastructure can be reused.Cool, well if you get it working with xl and a modern please let us know, it would make a useful addition to the testing... Ian