Xen devel - Sep 2013 - [PATCH RFC 1/2] xen/arm: remove cast in mmu_init_secondary_cpu

At this moment, virt_to_maddr() is casted with 32 bit and this makes an error
when 64 bit address is returned.
This cast needs to be removed. 


Singed-off-by: ChanJu Park 
Singed-off-by: Min Kang 
---
xen/arch/arm/mm.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 69c157a..bdfb7af 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -520,7 +520,7 @@ void __cpuinit mmu_init_secondary_cpu(void)
     uint64_t ttbr;

     /* Change to this CPU''s pagetables */
-    ttbr = (uintptr_t)virt_to_maddr(THIS_CPU_PGTABLE);
+    ttbr = virt_to_maddr(THIS_CPU_PGTABLE);
     WRITE_TTBR(ttbr);

     /* From now on, no mapping may be both writable and executable. */
-- 
1.7.9.5

On Tue, 2013-09-17 at 15:30 +0000, ChanJu Park wrote:
> At this moment, virt_to_maddr() is casted with 32 bit and this makes an
error when 64 bit address is returned.
> This cast needs to be removed. 
> 
> 
> Singed-off-by: ChanJu Park 
> Singed-off-by: Min Kang 
Please can you include your email addresses here?

Acked-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> xen/arch/arm/mm.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 69c157a..bdfb7af 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -520,7 +520,7 @@ void __cpuinit mmu_init_secondary_cpu(void)
>      uint64_t ttbr;
> 
>      /* Change to this CPU''s pagetables */
> -    ttbr = (uintptr_t)virt_to_maddr(THIS_CPU_PGTABLE);
> +    ttbr = virt_to_maddr(THIS_CPU_PGTABLE);
>      WRITE_TTBR(ttbr);
> 
>      /* From now on, no mapping may be both writable and executable. */

> Please can you include your email addresses here?
Oh, sorry for my mistake.
Email information may be missed during company mail sending.
I''d like to rewrite this information as follows.
    Singed-off-by: ChanJu Park <bestworld@samsung.com>
    Singed-off-by: Min Kang <min1023.kang@samsung.com>

And from next patch, I''ll try the git send-email as you recommended.
Thank you much,

ChanJu Park

------- Original Message -------
Sender : Ian Campbell<ian.campbell@citrix.com>
Date : 2013-09-18 00:39 (GMT+09:00)
Title : Re: [Xen-devel][PATCH RFC 1/2] xen/arm: remove cast in
mmu_init_secondary_cpu

On Tue, 2013-09-17 at 15:30 +0000, ChanJu Park wrote:
> At this moment, virt_to_maddr() is casted with 32 bit and this makes an
error when 64 bit address is returned.
> This cast needs to be removed. 
> 
> 
> Singed-off-by: ChanJu Park 
> Singed-off-by: Min Kang 
Please can you include your email addresses here?

Acked-by: Ian Campbell 
> ---
> xen/arch/arm/mm.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 69c157a..bdfb7af 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -520,7 +520,7 @@ void __cpuinit mmu_init_secondary_cpu(void)
>      uint64_t ttbr;
> 
>      /* Change to this CPU''s pagetables */
> -    ttbr = (uintptr_t)virt_to_maddr(THIS_CPU_PGTABLE);
> +    ttbr = virt_to_maddr(THIS_CPU_PGTABLE);
>      WRITE_TTBR(ttbr);
> 
>      /* From now on, no mapping may be both writable and executable. */

On Tue, 2013-09-17 at 16:30 +0000, ChanJu Park wrote:
> > Please can you include your email addresses here?
> 
> Oh, sorry for my mistake.
No problem.
> Email information may be missed during company mail sending.
> I''d like to rewrite this information as follows.
>     Singed-off-by: ChanJu Park <bestworld@samsung.com>
>     Singed-off-by: Min Kang <min1023.kang@samsung.com>
I did wonder if something had tried to parse it as html and hidden the
<> or something ;-)
> And from next patch, I''ll try the git send-email as you
recommended.
Cheers,
Ian.