Peter Maydell
2013-Aug-29 08:48 UTC
Re: [Qemu-devel] [PATCH for v1.6] pc: Fix initialization of the ram_memory variable.
On 16 August 2013 15:46, Anthony PERARD <anthony.perard@citrix.com> wrote:> In some cases (Xen), it will not be initialized before to be used. This > leads to segv. > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> > > --- > > It works with this simple initialization to NULL, but would it be > necessary (or better) to assign a proper value to this variables ?Yes, is this really the right fix? I raised this before 1.6 came out (since clang complains about it): http://lists.gnu.org/archive/html/qemu-devel/2013-07/msg05383.html (though I see I got the sense of the conditional wrong in the subject line of that mail) and Stefano suggested the right fix was more complicated than just passing NULL. Also IIRC if you follow the variable down then it eventually gets actually used by code, so just passing NULL sounds wrong. thanks -- PMM