Xen devel - Aug 2013 - [PATCH] Correct X2-APIC HVM emulation

commit 6859874b61d5ddaf5289e72ed2b2157739b72ca5 introduced an error for the
hvm emulation of x2apic. Any try to write to APIC_ICR MSR will result in
a gp fault.

Signed-off-by: Juergen Gross <juergen.gross@ts.fujitsu.com>
---
 xen/arch/x86/hvm/vlapic.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
index 7a154f9..366dfc9 100644
--- a/xen/arch/x86/hvm/vlapic.c
+++ b/xen/arch/x86/hvm/vlapic.c
@@ -859,6 +859,7 @@ int hvm_x2apic_msr_write(struct vcpu *v, unsigned int msr,
uint64_t msr_content)
         rc = vlapic_reg_write(v, APIC_ICR2, (uint32_t)(msr_content >>
32));
         if ( rc )
             return rc;
+        break;
 
     case APIC_ICR2:
         return X86EMUL_UNHANDLEABLE;
-- 
1.7.10.4

On 22/08/2013 10:15, "Juergen Gross"
<juergen.gross@ts.fujitsu.com> wrote:
> commit 6859874b61d5ddaf5289e72ed2b2157739b72ca5 introduced an error for the
> hvm emulation of x2apic. Any try to write to APIC_ICR MSR will result in
> a gp fault.
> 
> Signed-off-by: Juergen Gross <juergen.gross@ts.fujitsu.com>
Acked-by: Keir Fraser <keir@xen.org>