Signed-off-by: Vincent Bernardoff <vincent.bernardoff@citrix.com> --- docs/man/xl.cfg.pod.5 | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5 index 08d6cc4..def07d4 100644 --- a/docs/man/xl.cfg.pod.5 +++ b/docs/man/xl.cfg.pod.5 @@ -1174,8 +1174,6 @@ The form usbdevice=DEVICE is also accepted for backwards compatibility. More valid options can be found in the "usbdevice" section of the qemu documentation. -=back - =item B<vendor_device="VENDOR_DEVICE"> Selects which variant of the QEMU xen-pvdevice should be used for this -- 1.8.3.4
On Fri, Aug 16, 2013 at 03:45:42PM +0100, Vincent Bernardoff wrote:> Signed-off-by: Vincent Bernardoff <vincent.bernardoff@citrix.com> > --- > docs/man/xl.cfg.pod.5 | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5 > index 08d6cc4..def07d4 100644 > --- a/docs/man/xl.cfg.pod.5 > +++ b/docs/man/xl.cfg.pod.5 > @@ -1174,8 +1174,6 @@ The form usbdevice=DEVICE is also accepted for backwards compatibility. > More valid options can be found in the "usbdevice" section of the qemu > documentation. > > -=back > -Could you explain in the commit message why this is broken? Wei.> =item B<vendor_device="VENDOR_DEVICE"> > > Selects which variant of the QEMU xen-pvdevice should be used for this > -- > 1.8.3.4 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel
On Fri, 2013-08-16 at 18:56 +0100, Wei Liu wrote:> On Fri, Aug 16, 2013 at 03:45:42PM +0100, Vincent Bernardoff wrote: > > Signed-off-by: Vincent Bernardoff <vincent.bernardoff@citrix.com> > > --- > > docs/man/xl.cfg.pod.5 | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5 > > index 08d6cc4..def07d4 100644 > > --- a/docs/man/xl.cfg.pod.5 > > +++ b/docs/man/xl.cfg.pod.5 > > @@ -1174,8 +1174,6 @@ The form usbdevice=DEVICE is also accepted for backwards compatibility. > > More valid options can be found in the "usbdevice" section of the qemu > > documentation. > > > > -=back > > - > > Could you explain in the commit message why this is broken?Is this the same class of issue as the Perl 5.18 increased pod2man strictness in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=719506 ? At a minimum I think the commit message needs to include the error message. Ian.
On Fri, Aug 16, 2013 at 7:40 PM, Ian Campbell <ian.campbell@citrix.com> wrote:> On Fri, 2013-08-16 at 18:56 +0100, Wei Liu wrote: >> On Fri, Aug 16, 2013 at 03:45:42PM +0100, Vincent Bernardoff wrote: >> > Signed-off-by: Vincent Bernardoff <vincent.bernardoff@citrix.com> >> > --- >> > docs/man/xl.cfg.pod.5 | 2 -- >> > 1 file changed, 2 deletions(-) >> > >> > diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5 >> > index 08d6cc4..def07d4 100644 >> > --- a/docs/man/xl.cfg.pod.5 >> > +++ b/docs/man/xl.cfg.pod.5 >> > @@ -1174,8 +1174,6 @@ The form usbdevice=DEVICE is also accepted for backwards compatibility. >> > More valid options can be found in the "usbdevice" section of the qemu >> > documentation. >> > >> > -=back >> > - >> >> Could you explain in the commit message why this is broken? > > Is this the same class of issue as the Perl 5.18 increased pod2man > strictness in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=719506 ? >I reckon so.> At a minimum I think the commit message needs to include the error > message. >Right. Wei.> Ian. > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel