Roger Pau Monne
2013-Jul-08 13:03 UTC
[PATCH RFC 0/4] xen-block: prevent blkfront for hoarding grants
The following patches prevent blkfront from hoarding all grants in the system by allowing blkfront to request blkback to unmap certain grants so they can be freed by blkfront. This is done periodically by blkfront, unmapping a certain amount of unused persistent grants. This series also includes a bug fix for the grant table free callback implementation. According to my tests, this series don''t introduce any performance regressions, results can be seen at: http://xenbits.xen.org/people/royger/persistent_unmap/
David Vrabel
2013-Jul-11 13:35 UTC
Re: [PATCH RFC 0/4] xen-block: prevent blkfront for hoarding grants
On 08/07/13 14:03, Roger Pau Monne wrote:> This series also includes a bug fix for the grant table free callback > implementation.I think this should have been split out from this series.> According to my tests, this series don''t introduce any performance > regressions, results can be seen at: > > http://xenbits.xen.org/people/royger/persistent_unmap/The graphs do show performance differences (although they don''t look significant). They are also lacking any error bars or any explanation of what the tests were and what the test system was. David
Roger Pau Monné
2013-Jul-31 09:50 UTC
Re: [PATCH RFC 0/4] xen-block: prevent blkfront for hoarding grants
On 08/07/13 15:03, Roger Pau Monne wrote:> The following patches prevent blkfront from hoarding all grants in the > system by allowing blkfront to request blkback to unmap certain grants > so they can be freed by blkfront. This is done periodically by > blkfront, unmapping a certain amount of unused persistent grants. > > This series also includes a bug fix for the grant table free callback > implementation.Hello, IMHO I think 1 should go in (at the end it''s a bugfix) and backported to stable. 2 and 4 (second version) can probably also go in? Roger.
Konrad Rzeszutek Wilk
2013-Jul-31 11:27 UTC
Re: [PATCH RFC 0/4] xen-block: prevent blkfront for hoarding grants
"Roger Pau Monné" <roger.pau@citrix.com> wrote:>On 08/07/13 15:03, Roger Pau Monne wrote: >> The following patches prevent blkfront from hoarding all grants in >the >> system by allowing blkfront to request blkback to unmap certain >grants >> so they can be freed by blkfront. This is done periodically by >> blkfront, unmapping a certain amount of unused persistent grants. >> >> This series also includes a bug fix for the grant table free callback > >> implementation. > >Hello, > >IMHO I think 1 should go in (at the end it's a bugfix) and backported >to >stable. 2 and 4 (second version) can probably also go in? > >Roger.Can you repost the patch series please with some of the comments addressed in the commit description please. Note that the patch series It says RFC on them :-) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel