There is a typo here, "i" vs "j", so we would crash on
module_exit().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/xen-netback/netback.c
b/drivers/net/xen-netback/netback.c
index a0b50ad..130bcb2 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -1968,8 +1968,8 @@ static void __exit netback_fini(void)
del_timer_sync(&netbk->net_timer);
kthread_stop(netbk->task);
for (j = 0; j < MAX_PENDING_REQS; j++) {
- if (netbk->mmap_pages[i])
- __free_page(netbk->mmap_pages[i]);
+ if (netbk->mmap_pages[j])
+ __free_page(netbk->mmap_pages[j]);
}
}
On Fri, Jun 21, 2013 at 09:20:08AM +0300, Dan Carpenter wrote:> There is a typo here, "i" vs "j", so we would crash on module_exit(). > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c > index a0b50ad..130bcb2 100644 > --- a/drivers/net/xen-netback/netback.c > +++ b/drivers/net/xen-netback/netback.c > @@ -1968,8 +1968,8 @@ static void __exit netback_fini(void) > del_timer_sync(&netbk->net_timer); > kthread_stop(netbk->task); > for (j = 0; j < MAX_PENDING_REQS; j++) { > - if (netbk->mmap_pages[i]) > - __free_page(netbk->mmap_pages[i]); > + if (netbk->mmap_pages[j]) > + __free_page(netbk->mmap_pages[j]);Nice catch, thanks. Wei.
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Fri, 21 Jun 2013 09:20:08 +0300> There is a typo here, "i" vs "j", so we would crash on module_exit(). > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>Please always explicitly state the tree for which a patch is applicable. Here I figured it out by trial an error, trying to apply it to ''net'' (where it failed) and then ''net-next'' (where it applied cleanly). I should never have to play patch monkey games like that, you need to tell me where a patch is targetted. Thanks. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 24 Jun 2013, David Miller wrote:> From: Dan Carpenter <dan.carpenter@oracle.com> > Date: Fri, 21 Jun 2013 09:20:08 +0300 > > > There is a typo here, "i" vs "j", so we would crash on module_exit(). > > > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > Please always explicitly state the tree for which a patch is > applicable. > > Here I figured it out by trial an error, trying to apply it > to ''net'' (where it failed) and then ''net-next'' (where it > applied cleanly). > > I should never have to play patch monkey games like that, you > need to tell me where a patch is targetted.Shouldn''t one always, by default, work on linux-next? julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Julia Lawall <julia.lawall@lip6.fr> Date: Mon, 24 Jun 2013 08:31:31 +0100 (BST)> On Mon, 24 Jun 2013, David Miller wrote: > >> From: Dan Carpenter <dan.carpenter@oracle.com> >> Date: Fri, 21 Jun 2013 09:20:08 +0300 >> >> > There is a typo here, "i" vs "j", so we would crash on module_exit(). >> > >> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> >> >> Please always explicitly state the tree for which a patch is >> applicable. >> >> Here I figured it out by trial an error, trying to apply it >> to ''net'' (where it failed) and then ''net-next'' (where it >> applied cleanly). >> >> I should never have to play patch monkey games like that, you >> need to tell me where a patch is targetted. > > Shouldn''t one always, by default, work on linux-next?Bug fixes, especially serious ones, should be targetted at ''net''.