Dario Faggioli
2013-Jun-07 16:14 UTC
[PATCH v2] libxl: add LIBXL_HAVE_<foo> for outstanding_pages and outstanding_memkb
Commits d0782481 ("xl: export ''outstanding_pages'' value
from xcinfo")
and bec8f17e ("xen: Remove the XENMEM_get_oustanding_pages and provide
the data via xc_phys_info") added these two fields in libxl_physinfo
and in libxl_dominfo, respectively, but did not include the needed
LIBXL_HAVE_<foo> runes. Adding them.
Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
---
Changes from v1:
* updated changelog with the summary of the referenced commits
* updated the code comments as requested during review
---
tools/libxl/libxl.h | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
index 0bc005e..37e4d82 100644
--- a/tools/libxl/libxl.h
+++ b/tools/libxl/libxl.h
@@ -318,6 +318,24 @@
#define LIBXL_HAVE_NONCONST_EVENT_OCCURS_EVENT_ARG 1
#endif
+/*
+ * LIBXL_HAVE_PHYSINFO_OUTSTANDING_PAGES
+ *
+ * If this is defined, libxl_physinfo structure will contain an uint64 field
+ * called outstanding_pages, containing the number of pages claimed but not
+ * yet allocated for all domains.
+ */
+#define LIBXL_HAVE_PHYSINFO_OUTSTANDING_PAGES 1
+
+/*
+ * LIBXL_HAVE_DOMINFO_OUTSTANDING_MEMKB 1
+ *
+ * If this is defined, libxl_dominfo will contain a MemKB type field called
+ * outstanding_memkb, containing the amount of claimed but not yet allocated
+ * memory for a specific domain.
+ */
+#define LIBXL_HAVE_DOMINFO_OUTSTANDING_MEMKB 1
+
/* Functions annotated with LIBXL_EXTERNAL_CALLERS_ONLY may not be
* called from within libxl itself. Callers outside libxl, who
* do not #include libxl_internal.h, are fine. */
Ian Campbell
2013-Jun-12 09:44 UTC
Re: [PATCH v2] libxl: add LIBXL_HAVE_<foo> for outstanding_pages and outstanding_memkb
On Fri, 2013-06-07 at 18:14 +0200, Dario Faggioli wrote:> Commits d0782481 ("xl: export ''outstanding_pages'' value from xcinfo") > and bec8f17e ("xen: Remove the XENMEM_get_oustanding_pages and provide > the data via xc_phys_info") added these two fields in libxl_physinfo > and in libxl_dominfo, respectively, but did not include the needed > LIBXL_HAVE_<foo> runes. Adding them. > > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > Acked-by: George Dunlap <george.dunlap@eu.citrix.com>Applied, thanks