Ian Campbell
2013-May-31 11:50 UTC
Re: [libvirt] [PATCH] libxl: allow an <emulator> to be selected in the domain config XML
On Fri, 2013-05-31 at 13:14 +0200, Marek Marczykowski wrote:> >> Optional attribute for <emulator> tag? Maybe sth like: > >> <emulator type="stubdom">/usr/lib/xen/boot/ioemu-stubdom.gz</emulator> > >> ? > > > > FWIW the path can be omitted and libxl will DTRT. > > Indeed. It looks like libxl even doesn''t allow custom stubdom path - always > uses hardcoded default. libxl_dm.c: > stubdom_state->pv_kernel.path > = libxl__abs_path(gc, "ioemu-stubdom.gz", libxl__xenfirmwaredir_path()); > stubdom_state->pv_cmdline = libxl__sprintf(gc, " -d %d", guest_domid); > stubdom_state->pv_ramdisk.path = "";So it does. FWIW given libxl allows an override for the process type of qemu I can''t think why we wouldn''t allow an override here too.> IMO it is much more useful to specify device model type (qemu upstream, qemu > traditional, qemu traditional in stubdom) than explicit qemu path,I agree. Users should not generally need to care about paths to things. Ian.