Christoph Egger
2013-May-30 12:06 UTC
[PATCH] tools/libxl: fix array subscript has type ''char''
commit cad172d7b88bd443c81d865051297875ce2551bc Author: Christoph Egger <chegger@amazon.de> Date: Thu Feb 7 14:42:29 2013 +0000 tools/libxl: fix array subscript has type ''char'' Signed-off-by: Christoph Egger <chegger@amazon.de> Reviewed-by: Matt Wilson <msw@amazon.com> diff --git a/tools/libxl/libxl_utils.c b/tools/libxl/libxl_utils.c index 35da71c..0c039b1 100644 --- a/tools/libxl/libxl_utils.c +++ b/tools/libxl/libxl_utils.c @@ -95,7 +95,7 @@ int libxl_domain_qualifier_to_domid(libxl_ctx *ctx, const char *name, { int i, rv; for (i=0; name[i]; i++) { - if (!isdigit(name[i])) { + if (!isdigit((unsigned char)name[i])) { goto nondigit_found; } } _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Ian Campbell
2013-May-30 12:10 UTC
Re: [PATCH] tools/libxl: fix array subscript has type ''char''
On Thu, 2013-05-30 at 14:06 +0200, Christoph Egger wrote:> commit cad172d7b88bd443c81d865051297875ce2551bc > Author: Christoph Egger <chegger@amazon.de> > Date: Thu Feb 7 14:42:29 2013 +0000 > > tools/libxl: fix array subscript has type ''char''Please use the CTYPE macro from libxl_internal.h. Ian.
Egger, Christoph
2013-May-30 12:12 UTC
Re: [PATCH] tools/libxl: fix array subscript has type ''char''
On 30.05.13 14:10, Ian Campbell wrote:> On Thu, 2013-05-30 at 14:06 +0200, Christoph Egger wrote: >> commit cad172d7b88bd443c81d865051297875ce2551bc >> Author: Christoph Egger <chegger@amazon.de> >> Date: Thu Feb 7 14:42:29 2013 +0000 >> >> tools/libxl: fix array subscript has type ''char'' > > Please use the CTYPE macro from libxl_internal.h.Oh, ok. I completely missend when that was introduced. Christoph