Jan Beulich
2013-May-29 12:31 UTC
[PATCH] xen-pciback: more uses of cached MSI-X capability offset
Signed-off-by: Jan Beulich <jbeulich@suse.com> --- drivers/xen/xen-pciback/pci_stub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- 3.10-rc3/drivers/xen/xen-pciback/pci_stub.c +++ 3.10-rc3-xen-pciback-MSI-X-cap/drivers/xen/xen-pciback/pci_stub.c @@ -106,7 +106,7 @@ static void pcistub_device_release(struc else pci_restore_state(dev); - if (pci_find_capability(dev, PCI_CAP_ID_MSIX)) { + if (dev->msix_cap) { struct physdev_pci_device ppdev = { .seg = pci_domain_nr(dev->bus), .bus = dev->bus->number, @@ -371,7 +371,7 @@ static int pcistub_init_device(struct pc if (err) goto config_release; - if (pci_find_capability(dev, PCI_CAP_ID_MSIX)) { + if (dev->msix_cap) { struct physdev_pci_device ppdev = { .seg = pci_domain_nr(dev->bus), .bus = dev->bus->number,
Bjorn Helgaas
2013-May-29 20:51 UTC
Re: [PATCH] xen-pciback: more uses of cached MSI-X capability offset
On Wed, May 29, 2013 at 6:31 AM, Jan Beulich <JBeulich@suse.com> wrote:> Signed-off-by: Jan Beulich <jbeulich@suse.com> > > --- > drivers/xen/xen-pciback/pci_stub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)Acked-by: Bjorn Helgaas <bhelgaas@google.com> I assume you''ll take this, Konrad. Let me know if you need me to do anything.> --- 3.10-rc3/drivers/xen/xen-pciback/pci_stub.c > +++ 3.10-rc3-xen-pciback-MSI-X-cap/drivers/xen/xen-pciback/pci_stub.c > @@ -106,7 +106,7 @@ static void pcistub_device_release(struc > else > pci_restore_state(dev); > > - if (pci_find_capability(dev, PCI_CAP_ID_MSIX)) { > + if (dev->msix_cap) { > struct physdev_pci_device ppdev = { > .seg = pci_domain_nr(dev->bus), > .bus = dev->bus->number, > @@ -371,7 +371,7 @@ static int pcistub_init_device(struct pc > if (err) > goto config_release; > > - if (pci_find_capability(dev, PCI_CAP_ID_MSIX)) { > + if (dev->msix_cap) { > struct physdev_pci_device ppdev = { > .seg = pci_domain_nr(dev->bus), > .bus = dev->bus->number, > > >
Konrad Rzeszutek Wilk
2013-May-29 21:03 UTC
Re: [PATCH] xen-pciback: more uses of cached MSI-X capability offset
On Wed, May 29, 2013 at 02:51:11PM -0600, Bjorn Helgaas wrote:> On Wed, May 29, 2013 at 6:31 AM, Jan Beulich <JBeulich@suse.com> wrote: > > Signed-off-by: Jan Beulich <jbeulich@suse.com> > > > > --- > > drivers/xen/xen-pciback/pci_stub.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Acked-by: Bjorn Helgaas <bhelgaas@google.com> > > I assume you''ll take this, Konrad. Let me know if you need me to do anything.Yes, in my queue as we speak. Thanks.> > > --- 3.10-rc3/drivers/xen/xen-pciback/pci_stub.c > > +++ 3.10-rc3-xen-pciback-MSI-X-cap/drivers/xen/xen-pciback/pci_stub.c > > @@ -106,7 +106,7 @@ static void pcistub_device_release(struc > > else > > pci_restore_state(dev); > > > > - if (pci_find_capability(dev, PCI_CAP_ID_MSIX)) { > > + if (dev->msix_cap) { > > struct physdev_pci_device ppdev = { > > .seg = pci_domain_nr(dev->bus), > > .bus = dev->bus->number, > > @@ -371,7 +371,7 @@ static int pcistub_init_device(struct pc > > if (err) > > goto config_release; > > > > - if (pci_find_capability(dev, PCI_CAP_ID_MSIX)) { > > + if (dev->msix_cap) { > > struct physdev_pci_device ppdev = { > > .seg = pci_domain_nr(dev->bus), > > .bus = dev->bus->number, > > > > > >