Konrad Rzeszutek Wilk
2013-May-28 13:53 UTC
Re: [PATCH 2] xmem/tmem: fix ''undefined variable'' build error.
On Sat, May 25, 2013 at 10:48:57PM +0200, Frederico Cadete wrote:> In the (not so useful) kernel configuration where CONFIG_SWAP > is undefined and CONFIG_XEN_SELFBALLOONING is defined, > xen_tmem_init would use undefined variable ''static bool frontswap''. > > Added #else to have #define frontswap (0) in the case where > CONFIG_FRONTSWAP is not defined.You are missing an Signed-off-by here. Are you OK affixing it here? The rules for that are (from Documention/SubmittingPatches): The sign-off is a simple line at the end of the explanation for the patch, which certifies that you wrote it or otherwise have the right to pass it on as an open-source patch. The rules are pretty simple: if you can certify the below: Developer''s Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. then you just add a line saying Signed-off-by: Random J Developer <random@developer.example.org> using your real name (sorry, no pseudonyms or anonymous contributions.)> --- > drivers/xen/tmem.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/xen/tmem.c b/drivers/xen/tmem.c > index 18e8bd8..cc072c6 100644 > --- a/drivers/xen/tmem.c > +++ b/drivers/xen/tmem.c > @@ -41,6 +41,8 @@ module_param(selfballooning, bool, S_IRUGO); > #ifdef CONFIG_FRONTSWAP > static bool frontswap __read_mostly = true; > module_param(frontswap, bool, S_IRUGO); > +#else /* CONFIG_FRONTSWAP */ > +#define frontswap (0) > #endif /* CONFIG_FRONTSWAP */ > > #ifdef CONFIG_XEN_SELFBALLOONING > -- > 1.7.9.5 >
Frederico Cadete
2013-May-28 14:39 UTC
Re: [PATCH 2] xmem/tmem: fix ''undefined variable'' build error.
On Tue, May 28, 2013 at 09:53:21AM -0400, Konrad Rzeszutek Wilk wrote:> You are missing an Signed-off-by here. Are you OK affixing it here? >Sorry, my bad. And checkpatch warned me about that... A fixed version of the patch follows below. Thanks for being so patient. Regards, Frederico From: Frederico Cadete <frederico@cadete.eu> Date: Tue, 28 May 2013 16:19:49 +0200 Subject: [PATCH 2] xmem/tmem: fix ''undefined variable'' build error. In the (not so useful) kernel configuration where CONFIG_SWAP is undefined and CONFIG_XEN_SELFBALLOONING is defined, xen_tmem_init would use undefined variable ''static bool frontswap''. Added #else to have #define frontswap (0) in the case where CONFIG_FRONTSWAP is not defined. Signed-off-by: Frederico Cadete <frederico@cadete.eu> --- drivers/xen/tmem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/xen/tmem.c b/drivers/xen/tmem.c index 18e8bd8..cc072c6 100644 --- a/drivers/xen/tmem.c +++ b/drivers/xen/tmem.c @@ -41,6 +41,8 @@ module_param(selfballooning, bool, S_IRUGO); #ifdef CONFIG_FRONTSWAP static bool frontswap __read_mostly = true; module_param(frontswap, bool, S_IRUGO); +#else /* CONFIG_FRONTSWAP */ +#define frontswap (0) #endif /* CONFIG_FRONTSWAP */ #ifdef CONFIG_XEN_SELFBALLOONING -- 1.7.9.5