Emile `iMil'' Heitor
2013-May-26 08:23 UTC
add_to_VCPUs_params_live regression in xend 4.1+ XenAPI
Hi,
It seems a regression has been introduced in xen''d XenAPI a while ago:
http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=832656a1796170a11fc72035cae542a383a8843c
When calling VM.add_to_VCPUs_params_live(), beginning with version 4.1,
you''ll receive the following message:
Failure: Internal error: (22, ''Invalid argument'').
And watching xend''s log you could witness:
Traceback (most recent call last):
File "/usr/pkg/lib/python2.7/site-packages/xen/xend/XendAPI.py",
line 1656, in _VM_VCPUs_params_refresh
cpus = map(int, value)
File "/usr/pkg/lib/python2.7/site-packages/xen/xend/XendDomain.py",
line 1609, in domain_pincpu
cpumap = map(int, cpumap.split(","))
AttributeError: ''list'' object has no attribute
''split''
[2013-05-26 09:40:07 407] ERROR (XendDomain:1832) (22, ''Invalid
argument'')
While reading current version of XendAPI.py, we still can see
cpus = map(int, value.split(",")) which will fail as `value''
is already
a list.
Reverting to xendom.domain_pincpu(xeninfo.getDomid(), vcpu, value) makes
VM.add_to_VCPUs_params_live() work again, tested on 4.1.
I know xend is marked as `deprecated'', but the fact is there''s
no successor
when it comes to XenAPI on various systems at the moment. Can this be
reverted and maybe pulled-up?
Thanks,
------------------------------------------------------------------
Emile `iMil'' Heitor .°.
<imil@{home.imil.net,NetBSD.org,gcu.info}>
_
| http://imil.net | ASCII ribbon campaign ( )
| http://www.NetBSD.org | - against HTML email X
| http://gcu.info | & vCards / \
Pasi Kärkkäinen
2013-May-26 10:27 UTC
Re: add_to_VCPUs_params_live regression in xend 4.1+ XenAPI
On Sun, May 26, 2013 at 10:23:50AM +0200, Emile `iMil'' Heitor wrote:> > Hi, > > It seems a regression has been introduced in xen''d XenAPI a while ago: > > http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=832656a1796170a11fc72035cae542a383a8843c > > When calling VM.add_to_VCPUs_params_live(), beginning with version 4.1, > you''ll receive the following message: > > Failure: Internal error: (22, ''Invalid argument''). > > And watching xend''s log you could witness: > > Traceback (most recent call last): > File "/usr/pkg/lib/python2.7/site-packages/xen/xend/XendAPI.py", line 1656, in _VM_VCPUs_params_refresh > cpus = map(int, value) > File "/usr/pkg/lib/python2.7/site-packages/xen/xend/XendDomain.py", line 1609, in domain_pincpu > cpumap = map(int, cpumap.split(",")) > AttributeError: ''list'' object has no attribute ''split'' > [2013-05-26 09:40:07 407] ERROR (XendDomain:1832) (22, ''Invalid argument'') > > While reading current version of XendAPI.py, we still can see > cpus = map(int, value.split(",")) which will fail as `value'' is already > a list. > > Reverting to xendom.domain_pincpu(xeninfo.getDomid(), vcpu, value) makes > VM.add_to_VCPUs_params_live() work again, tested on 4.1. > > I know xend is marked as `deprecated'', but the fact is there''s no successor > when it comes to XenAPI on various systems at the moment. Can this be > reverted and maybe pulled-up? >''xapi'' toolstack is the successor, and it has a proper XenAPI implementation. xend never had proper xenapi implementation. -- Pasi
Emile `iMil'' Heitor
2013-May-26 11:41 UTC
Re: add_to_VCPUs_params_live regression in xend 4.1+ XenAPI
On Sun, 26 May 2013, Pasi Kärkkäinen wrote:>> I know xend is marked as `deprecated'', but the fact is there''s no successor >> when it comes to XenAPI on various systems at the moment. Can this be >> reverted and maybe pulled-up? >> > > ''xapi'' toolstack is the successor, and it has a proper XenAPI implementation. > xend never had proper xenapi implementation.As I said, I know xend is deprecated, but xapi doesn''t seem to be available as a standalone solution without all the XCP eco-system on the OS we use aka Debian (and probably others). Thing is, while XCP is a superb solution itself, it doesn''t go well with specific network architectures as it want (at least on Debian) to have control on bridges, which we cannot allow as we bring a bridge up on initrd in order to boot up dom0''s from PXE on a dedicated bridge. Any idea would be welcome though... Note I''d be glad to use xapi instead of a deprecated solution, but as of today it just can''t fit on our environment. There are many distros out there which haven''t yet moved neither to xapi, nor even to Xen 4.2, and they will eventually be bitten by that bug, which is very trivial to fix, thus my request. Thanks, ------------------------------------------------------------------ Emile `iMil'' Heitor .°. <imil@{home.imil.net,NetBSD.org,gcu.info}> _ | http://imil.net | ASCII ribbon campaign ( ) | http://www.NetBSD.org | - against HTML email X | http://gcu.info | & vCards / \
Pasi Kärkkäinen
2013-May-27 07:33 UTC
Re: add_to_VCPUs_params_live regression in xend 4.1+ XenAPI
On Sun, May 26, 2013 at 01:41:29PM +0200, Emile `iMil'' Heitor wrote:> On Sun, 26 May 2013, Pasi Kärkkäinen wrote: > > >>I know xend is marked as `deprecated'', but the fact is there''s no successor > >>when it comes to XenAPI on various systems at the moment. Can this be > >>reverted and maybe pulled-up? > >> > > > >''xapi'' toolstack is the successor, and it has a proper XenAPI implementation. > >xend never had proper xenapi implementation. > > As I said, I know xend is deprecated, but xapi doesn''t seem to be available > as a standalone solution without all the XCP eco-system on the OS we use aka > Debian (and probably others). > Thing is, while XCP is a superb solution itself, it doesn''t go well with > specific network architectures as it want (at least on Debian) to have > control on bridges, which we cannot allow as we bring a bridge up on > initrd in order to boot up dom0''s from PXE on a dedicated bridge. Any idea > would be welcome though... > > Note I''d be glad to use xapi instead of a deprecated solution, but as of > today it just can''t fit on our environment. >Ok.> There are many distros out there which haven''t yet moved neither to xapi, > nor even to Xen 4.2, and they will eventually be bitten by that bug, which > is very trivial to fix, thus my request. >Please see: http://wiki.xen.org/wiki/Submitting_Xen_Patches You need to send a patch with proper Signed-Off-By line etc. Thanks, -- Pasi