Wei Liu
2013-May-20 23:02 UTC
[PATCH net-next 0/2] Xen network: split event channels support
This series adds a new feature called split event channels. In the original implementation, only one event channel is setup between frontend and backend. This is not ideal as TX notification interferes with RX notification. Using dedicated event channels for TX and RX solves this issue. Wei Liu (2): xen-netback: split event channels feature support xen-netfront: split event channels feature support drivers/net/xen-netback/common.h | 11 ++- drivers/net/xen-netback/interface.c | 87 ++++++++++++++--- drivers/net/xen-netback/netback.c | 7 +- drivers/net/xen-netback/xenbus.c | 40 ++++++-- drivers/net/xen-netfront.c | 181 +++++++++++++++++++++++++++++------ 5 files changed, 269 insertions(+), 57 deletions(-) -- 1.7.10.4
David Miller
2013-May-21 06:27 UTC
Re: [PATCH net-next 0/2] Xen network: split event channels support
If you use the same exact subject line in all of your patches in the series, nobody reading the shortlog can tell what''s different about them. You absolutely must resubmit this with more descriptive subject lines which more accurately describe what each patch uniquely does.
Wei Liu
2013-May-21 08:00 UTC
Re: [PATCH net-next 0/2] Xen network: split event channels support
On Mon, May 20, 2013 at 11:27:52PM -0700, David Miller wrote:> > If you use the same exact subject line in all of your patches in the > series, nobody reading the shortlog can tell what''s different about > them. > > You absolutely must resubmit this with more descriptive subject lines > which more accurately describe what each patch uniquely does.I''m not sure I get what you mean. Their subject lines look alike, but not exactly the same. So this patch set adds a new feature to Xen network device, which is called split event channels. The subject lines of two patches, one for frontend and one for backend, speak for themselves. No matter how I change the subject lines, they will probably still look alike except for the leading "xen-netfront / xen-netback". I can squash them into one changeset if that better suits your workflow, but it is better to leave them separate IMHO so that we can test them separately. Advice welcomed. Thanks Wei.
David Miller
2013-May-21 08:13 UTC
Re: [PATCH net-next 0/2] Xen network: split event channels support
From: Wei Liu <wei.liu2@citrix.com> Date: Tue, 21 May 2013 09:00:40 +0100> I''m not sure I get what you mean. Their subject lines look alike, but > not exactly the same.I see, the prefix is different, sorry about that.
Ian Campbell
2013-May-21 08:17 UTC
Re: [PATCH net-next 0/2] Xen network: split event channels support
On Tue, 2013-05-21 at 09:00 +0100, Wei Liu wrote:> On Mon, May 20, 2013 at 11:27:52PM -0700, David Miller wrote: > > > > If you use the same exact subject line in all of your patches in the > > series, nobody reading the shortlog can tell what''s different about > > them. > > > > You absolutely must resubmit this with more descriptive subject lines > > which more accurately describe what each patch uniquely does. > > I''m not sure I get what you mean. Their subject lines look alike, but > not exactly the same. > > So this patch set adds a new feature to Xen network device, which is > called split event channels. The subject lines of two patches, one for > frontend and one for backend, speak for themselves.This is true, but I wonder if peoples eyes tend to skip over the initial prefix.> No matter how I change the subject lines, they will probably still look > alike except for the leading "xen-netfront / xen-netback". I can squash > them into one changeset if that better suits your workflow, but it is > better to leave them separate IMHO so that we can test them separately. > > Advice welcomed.How about "xen-netback: Split event channel support for Xen Backend driver" and the equivalent for frontend? I''d prefer to keep it as two changesets if possible. Ian.
Wei Liu
2013-May-21 08:34 UTC
Re: [PATCH net-next 0/2] Xen network: split event channels support
On Tue, May 21, 2013 at 09:17:35AM +0100, Ian Campbell wrote: [...]> > How about "xen-netback: Split event channel support for Xen Backend > driver" and the equivalent for frontend? >Sure, this can avoid future confusion. Wei.