Hi, tools/misc/xencov.c fails to build. NetBSD does not have MAP_LOCKED. Christoph
Christoph Egger <chegger <at> amazon.de> writes:> > Hi, > > tools/misc/xencov.c fails to build. > NetBSD does not have MAP_LOCKED. > > Christoph >I wanted to test 4.3 on NetBSD but ended up with this problem too... In fact this happened before in other parts of the code... http://lists.xen.org/archives/html/xen-devel/2012-06/msg00576.html I guess this would fix it... #ifdef __NetBSD__ /* MAP_LOCKED is Linux specific. MAP_WIRED is NetBSD''s equivalent. */ #define MAP_LOCKED MAP_WIRED #endif Sadly I came across another error, still searching if it was already posted, otherwise I will!
> > Sadly I came across another error, still searching if it was already posted, > otherwise I will!Acctually the other error was about libxl (array subscript has type ''char'' ) this was already mentioned!> > > >
On Wed, 2013-05-22 at 23:43 +0000, Miguel Clara wrote:> Christoph Egger <chegger <at> amazon.de> writes: > > > > > Hi, > > > > tools/misc/xencov.c fails to build. > > NetBSD does not have MAP_LOCKED. > > > > Christoph > > > > I wanted to test 4.3 on NetBSD but ended up with this problem too... In fact > this happened before in other parts of the code... > http://lists.xen.org/archives/html/xen-devel/2012-06/msg00576.html > > I guess this would fix it...Please can you confirm and if so submit a patch See http://wiki.xen.org/wiki/Submitting_Xen_Patches for some hints on how to do that.> > #ifdef __NetBSD__ > /* MAP_LOCKED is Linux specific. MAP_WIRED is NetBSD''s equivalent. */ > #define MAP_LOCKED MAP_WIRED > #endif > > Sadly I came across another error, still searching if it was already posted, > otherwise I will! > > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel
On Thu, 2013-05-23 at 02:04 +0100, Miguel Clara wrote:> > > > Sadly I came across another error, still searching if it was already posted, > > otherwise I will! > > Acctually the other error was about libxl (array subscript has type > ''char'' ) this was already mentioned!DO you have a reference? Was there a patch? Ian.
For now I simply added the code to tools/misc/xencov.c Not sure if its the best way to do it. On Thu, May 23, 2013 at 10:13 AM, Ian Campbell <Ian.Campbell@citrix.com> wrote:> On Wed, 2013-05-22 at 23:43 +0000, Miguel Clara wrote: >> Christoph Egger <chegger <at> amazon.de> writes: >> >> > >> > Hi, >> > >> > tools/misc/xencov.c fails to build. >> > NetBSD does not have MAP_LOCKED. >> > >> > Christoph >> > >> >> I wanted to test 4.3 on NetBSD but ended up with this problem too... In fact >> this happened before in other parts of the code... >> http://lists.xen.org/archives/html/xen-devel/2012-06/msg00576.html >> >> I guess this would fix it... > > Please can you confirm and if so submit a patch > > See http://wiki.xen.org/wiki/Submitting_Xen_Patches for some hints on > how to do that. > >> >> #ifdef __NetBSD__ >> /* MAP_LOCKED is Linux specific. MAP_WIRED is NetBSD''s equivalent. */ >> #define MAP_LOCKED MAP_WIRED >> #endif >> >> Sadly I came across another error, still searching if it was already posted, >> otherwise I will! >> >> >> >> >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> http://lists.xen.org/xen-devel > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
here: http://www.gossamer-threads.com/lists/xen/devel/282660 - fix error: array subscript has type ''char'' On Thu, May 23, 2013 at 10:14 AM, Ian Campbell <Ian.Campbell@citrix.com> wrote:> On Thu, 2013-05-23 at 02:04 +0100, Miguel Clara wrote: >> > >> > Sadly I came across another error, still searching if it was already posted, >> > otherwise I will! >> >> Acctually the other error was about libxl (array subscript has type >> ''char'' ) this was already mentioned! > > DO you have a reference? Was there a patch? > > Ian. >
On 23.05.13 12:59, Miguel Clara wrote:> For now I simply added the code to tools/misc/xencov.c > > Not sure if its the best way to do it. > > On Thu, May 23, 2013 at 10:13 AM, Ian Campbell <Ian.Campbell@citrix.com> wrote: >> On Wed, 2013-05-22 at 23:43 +0000, Miguel Clara wrote: >>> Christoph Egger <chegger <at> amazon.de> writes: >>> >>>> >>>> Hi, >>>> >>>> tools/misc/xencov.c fails to build. >>>> NetBSD does not have MAP_LOCKED. >>>> >>>> Christoph >>>> >>> >>> I wanted to test 4.3 on NetBSD but ended up with this problem too... In fact >>> this happened before in other parts of the code... >>> http://lists.xen.org/archives/html/xen-devel/2012-06/msg00576.html >>> >>> I guess this would fix it... >> >> Please can you confirm and if so submit a patch >> >> See http://wiki.xen.org/wiki/Submitting_Xen_Patches for some hints on >> how to do that. >> >>> >>> #ifdef __NetBSD__ >>> /* MAP_LOCKED is Linux specific. MAP_WIRED is NetBSD''s equivalent. */ >>> #define MAP_LOCKED MAP_WIRED >>> #endif >>> >>> Sadly I came across another error, still searching if it was already posted, >>> otherwise I will!I send this as a proper patch. Please add your Signed-off-by. Christoph
Maybe Matching Threads
- tools/libxl: fix compilation and link errors on NetBSD
- [PATCH] tools/xenbackendd: make 'gmake clean' properly cleaning
- [PATCH v8] gcov: Coverage support
- Bug#812166: [PATCH] x86/mce: fix misleading indentation in init_nonfatal_mce_checker().
- [PATCH][TOOLS] pygrub: cleanup and support for NetBSD