The array mmap_pages is never touched in the initialization function. This is
remnant of mapping mechanism, which does exist upstream.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
drivers/net/xen-netback/netback.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/xen-netback/netback.c
b/drivers/net/xen-netback/netback.c
index 37984e6..295a9c2 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -1939,10 +1939,6 @@ static int __init netback_init(void)
failed_init:
while (--group >= 0) {
struct xen_netbk *netbk = &xen_netbk[group];
- for (i = 0; i < MAX_PENDING_REQS; i++) {
- if (netbk->mmap_pages[i])
- __free_page(netbk->mmap_pages[i]);
- }
del_timer(&netbk->net_timer);
kthread_stop(netbk->task);
}
--
1.7.10.4
On Mon, May 06, 2013 at 04:40:20PM +0100, Wei Liu wrote:> The array mmap_pages is never touched in the initialization function. This is > remnant of mapping mechanism, which does exist upstream. >This patch targets net-next. Thanks Wei.
From: Wei Liu <wei.liu2@citrix.com> Date: Mon, 6 May 2013 17:10:33 +0100> On Mon, May 06, 2013 at 04:40:20PM +0100, Wei Liu wrote: >> The array mmap_pages is never touched in the initialization function. This is >> remnant of mapping mechanism, which does exist upstream. >> > > This patch targets net-next.http://marc.info/?l=linux-netdev&m=136730964130303&w=2
On Mon, May 06, 2013 at 05:17:22PM +0100, David Miller wrote:> From: Wei Liu <wei.liu2@citrix.com> > Date: Mon, 6 May 2013 17:10:33 +0100 > > > On Mon, May 06, 2013 at 04:40:20PM +0100, Wei Liu wrote: > >> The array mmap_pages is never touched in the initialization function. This is > >> remnant of mapping mechanism, which does exist upstream. > >> > > > > This patch targets net-next. > > http://marc.info/?l=linux-netdev&m=136730964130303&w=2 > --Got it. Wei.> To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2013-05-06 at 16:40 +0100, Wei Liu wrote:> The array mmap_pages is never touched in the initialization function. This is > remnant of mapping mechanism, which does exist upstream.^not Can you add a quick note about to the changelog about where this array is now initialised and freed please, with that:> Signed-off-by: Wei Liu <wei.liu2@citrix.com>Acked-by: Ian Campbell <ian.campbell@citrix.com> Please resubmit when Dave opens net-next for new development. Ian.> --- > drivers/net/xen-netback/netback.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c > index 37984e6..295a9c2 100644 > --- a/drivers/net/xen-netback/netback.c > +++ b/drivers/net/xen-netback/netback.c > @@ -1939,10 +1939,6 @@ static int __init netback_init(void) > failed_init: > while (--group >= 0) { > struct xen_netbk *netbk = &xen_netbk[group]; > - for (i = 0; i < MAX_PENDING_REQS; i++) { > - if (netbk->mmap_pages[i]) > - __free_page(netbk->mmap_pages[i]); > - } > del_timer(&netbk->net_timer); > kthread_stop(netbk->task); > }