Stefano Stabellini
2013-Apr-29 17:04 UTC
[PATCH] xen/arm: do not call __cpu_disable on machine_halt
__cpu_disable shouldn''t be called on machine_halt, in fact it cannot succeed: cpu_disable_scheduler won''t be able to migrate away vcpus to others pcpus. Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> --- xen/arch/arm/shutdown.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/xen/arch/arm/shutdown.c b/xen/arch/arm/shutdown.c index c1b60af..61b5280 100644 --- a/xen/arch/arm/shutdown.c +++ b/xen/arch/arm/shutdown.c @@ -25,7 +25,6 @@ static void raw_machine_reset(void) static void halt_this_cpu(void *arg) { - __cpu_disable(); stop_cpu(); } -- 1.7.2.5
Ian Campbell
2013-Apr-30 10:58 UTC
Re: [PATCH] xen/arm: do not call __cpu_disable on machine_halt
On Mon, 2013-04-29 at 18:04 +0100, Stefano Stabellini wrote:> __cpu_disable shouldn''t be called on machine_halt, in fact it cannot > succeed: cpu_disable_scheduler won''t be able to migrate away vcpus to > others pcpus. > > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>Acked + applied.