Julien Grall
2013-Apr-26 13:16 UTC
[PATCH] xen/arm: Fix return value when write is ignored in VGIC
From: Anthony PERARD <anthony.perard@citrix.com>
If a write is ignored, the function should return success.
Currently Xen will throw a data abort exception if the write in VGIC is
ignored.
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
xen/arch/arm/vgic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
index 6cceb0f..6aaafe9 100644
--- a/xen/arch/arm/vgic.c
+++ b/xen/arch/arm/vgic.c
@@ -592,7 +592,7 @@ bad_width:
write_ignore:
if ( dabt.size != 2 ) goto bad_width;
- return 0;
+ return 1;
}
static int vgic_distr_mmio_check(struct vcpu *v, paddr_t addr)
--
1.7.10.4
Ian Campbell
2013-Apr-26 13:18 UTC
Re: [PATCH] xen/arm: Fix return value when write is ignored in VGIC
On Fri, 2013-04-26 at 14:16 +0100, Julien Grall wrote:> From: Anthony PERARD <anthony.perard@citrix.com> > > If a write is ignored, the function should return success. > > Currently Xen will throw a data abort exception if the write in VGIC is > ignored. > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>Acked-by: Ian Campbell <ian.campbell@citrix.com>> --- > xen/arch/arm/vgic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c > index 6cceb0f..6aaafe9 100644 > --- a/xen/arch/arm/vgic.c > +++ b/xen/arch/arm/vgic.c > @@ -592,7 +592,7 @@ bad_width: > > write_ignore: > if ( dabt.size != 2 ) goto bad_width; > - return 0; > + return 1; > } > > static int vgic_distr_mmio_check(struct vcpu *v, paddr_t addr)
Ian Campbell
2013-Apr-26 15:34 UTC
Re: [PATCH] xen/arm: Fix return value when write is ignored in VGIC
On Fri, 2013-04-26 at 14:18 +0100, Ian Campbell wrote:> On Fri, 2013-04-26 at 14:16 +0100, Julien Grall wrote: > > From: Anthony PERARD <anthony.perard@citrix.com> > > > > If a write is ignored, the function should return success. > > > > Currently Xen will throw a data abort exception if the write in VGIC is > > ignored. > > > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> > > Acked-by: Ian Campbell <ian.campbell@citrix.com>and applied. It''s not clear to me if under the DCO this should have had Julien''s S-o-b too -- I think strictly speaking yes. Ian.