Julien Grall
2013-Apr-25 18:39 UTC
[PATCH] arm64: Fix compilation error with EARLY_PRINTK disabled
arm64/head.S: Assembler messages: arm64/head.S:391: Error: operand 1 should be an integer register -- `mov pc,lr'' Signed-off-by: Julien Grall <julien.grall@linaro.org> --- xen/arch/arm/arm64/head.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index f0d9066..ef02899 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -388,6 +388,6 @@ init_uart: .global early_puts early_puts: puts: -putn: mov pc, lr +putn: ret #endif /* EARLY_UART_ADDRESS */ -- 1.7.10.4
Ian Campbell
2013-Apr-26 08:50 UTC
Re: [PATCH] arm64: Fix compilation error with EARLY_PRINTK disabled
On Thu, 2013-04-25 at 19:39 +0100, Julien Grall wrote:> arm64/head.S: Assembler messages: > arm64/head.S:391: Error: operand 1 should be an integer register -- `mov pc,lr'' > > Signed-off-by: Julien Grall <julien.grall@linaro.org>Acked-by: Ian Campbell <ian.campbell@citrix.com>> --- > xen/arch/arm/arm64/head.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index f0d9066..ef02899 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -388,6 +388,6 @@ init_uart: > .global early_puts > early_puts: > puts: > -putn: mov pc, lr > +putn: ret > > #endif /* EARLY_UART_ADDRESS */
Ian Campbell
2013-Apr-26 15:34 UTC
Re: [PATCH] arm64: Fix compilation error with EARLY_PRINTK disabled
On Fri, 2013-04-26 at 09:50 +0100, Ian Campbell wrote:> On Thu, 2013-04-25 at 19:39 +0100, Julien Grall wrote: > > arm64/head.S: Assembler messages: > > arm64/head.S:391: Error: operand 1 should be an integer register -- `mov pc,lr'' > > > > Signed-off-by: Julien Grall <julien.grall@linaro.org> > > Acked-by: Ian Campbell <ian.campbell@citrix.com>Applied, thanks.