Alex Bligh
2013-Apr-05 15:43 UTC
Re: [Qemu-devel] [PATCHv2 1/2] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect
Stefano, --On 5 April 2013 15:22:16 +0100 Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:>> @@ -756,6 +753,41 @@ static int blk_init(struct XenDevice *xendev) >> info |= VDISK_CDROM; >> } >> >> + blkdev->file_blk = BLOCK_SIZE; > > This is useless, you are setting file_blk twice. Just remove this please.Actually the problem was I failed to remove it from blk_connect on the qemu-upstream-unstable patch set. The qemu-upstream-4.2 patch set is fine. I''ve thus resent, with it still in blk_init, but removed from blk_connect. -- Alex Bligh