Xen devel - Mar 2013 - Re: preparing for 4.2.2 and 4.1.5 / libxl blktap2 patch

On Mar 27, 11:52am, Pasi =?iso-8859-1?Q?K=E4rkk=E4inen?= wrote:
} Subject: Re: [Xen-devel] preparing for 4.2.2 and 4.1.5 / libxl blktap2 pat

Hi, hope the day is going well for everyone.
> > I''d like to get the libxl blktap2 patch applied for 4.2.2,
> > it''s already in master / xen-unstable:
> 
> So these patches still need to be applied to Xen 4.2 branch:
> 
> "[PATCH] libxl: don''t launch more than one tapdisk process
for each disk"
>
http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommit;h=3Dec398660e89ca18bb>
8d061d5047d682bd383778a
> 
> Xen 4.2 backport of the above patch is here:
> http://lists.xen.org/archives/html/xen-devel/2013-03/msg00778.html
> 
> 
> And now there''s other tapdisk patch in xen-unstable aswell:
> 
> "tools: Retry blktap2 tapdisk message on interrupt":
>
http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommit;h=3D6cffb2b469a55032a>
2900ccb8776c0082f346758
> 
> Both are needed in Xen 4.2 branch, please backport/apply before next Xen
4.> 2.2-rc !
> 
> I''m asking because we''ve seen these problems with the
CentOS 6 Xen 4.2 rpms,
> and it''d be good to get them fixed in upstream Xen 4.2 aswell.
Ian raised a good point with respect to the read/write system calls in
the blktap2 control plane needing to handle EINTR as well.  We''ve
never seen this issue in the field but it should be handled.

I will see if I can get a patch spun today on top of my last patch to
add that if no one beats me to it.
> Thanks,
> 
> -- Pasi
Have a good afternoon.

Greg

}-- End of excerpt from Pasi =?iso-8859-1?Q?K=E4rkk=E4inen?
As always,
Dr. G.W. Wettstein, Ph.D.   Enjellic Systems Development, LLC.
4206 N. 19th Ave.           Specializing in information infra-structure
Fargo, ND  58102            development.
PH: 701-281-1686
FAX: 701-281-3949           EMAIL: greg@enjellic.com
------------------------------------------------------------------------------
"If ease of use is the highest goal, we should all be driving golf
carts."
                                -- Larry Wall

On Wed, Mar 27, 2013 at 07:51:05AM -0500, Dr. Greg Wettstein
wrote:
> > 
> > So these patches still need to be applied to Xen 4.2 branch:
> > 
> > "[PATCH] libxl: don''t launch more than one tapdisk
process for each disk"
> >
http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommit;h=3Dec398660e89ca18bb>
> 8d061d5047d682bd383778a
> > 
> > Xen 4.2 backport of the above patch is here:
> > http://lists.xen.org/archives/html/xen-devel/2013-03/msg00778.html
> > 
> > And now there''s other tapdisk patch in xen-unstable aswell:
> > 
> > "tools: Retry blktap2 tapdisk message on interrupt":
> >
http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommit;h=3D6cffb2b469a55032a>
> 2900ccb8776c0082f346758
> > 
> > Both are needed in Xen 4.2 branch, please backport/apply before next
Xen 4.> > 2.2-rc !
> > 
> > I''m asking because we''ve seen these problems with
the CentOS 6 Xen 4.2 rpms,
> > and it''d be good to get them fixed in upstream Xen 4.2
aswell.
> 
> Ian raised a good point with respect to the read/write system calls in
> the blktap2 control plane needing to handle EINTR as well.  We''ve
> never seen this issue in the field but it should be handled.
> 
> I will see if I can get a patch spun today on top of my last patch to
> add that if no one beats me to it.
> 
Ok, thanks! So that patch is now in master/xen-unstable aswell.

IanJ: These three patches from master need to be applied to Xen 4.2 branch. 
Let''s do it now before Xen 4.2.2-rc2.


"libxl: don''t launch more than one tapdisk process for each
disk":
http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=ec398660e89ca18bb8d061d5047d682bd383778a
(Xen 4.2 backport:
http://lists.xen.org/archives/html/xen-devel/2013-03/msg00778.html)

"tools: Retry blktap2 tapdisk message on interrupt":
http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=6cffb2b469a55032a2900ccb8776c0082f346758

"tools/blktap2: Handle read/write interrupts in blktap2 control
plane.":
http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=a5c800142cfc82159fcb85b47116cf296caebcc5


Thanks! 


-- Pasi

IanJ: ping? 2/3 of the blktap2 bugfix patches listed below are not yet applied
to 4.2 branch..

(all three patches below have passed xen-unstable/master automated tests).


Thanks,

-- Pasi

On Wed, Apr 03, 2013 at 09:42:23PM +0300, Pasi Kärkkäinen
wrote:
> On Wed, Mar 27, 2013 at 07:51:05AM -0500, Dr. Greg Wettstein wrote:
> > > 
> > > So these patches still need to be applied to Xen 4.2 branch:
> > > 
> > > "[PATCH] libxl: don''t launch more than one tapdisk
process for each disk"
> > >
http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommit;h=3Dec398660e89ca18bb>
> > 8d061d5047d682bd383778a
> > > 
> > > Xen 4.2 backport of the above patch is here:
> > >
http://lists.xen.org/archives/html/xen-devel/2013-03/msg00778.html
> > > 
> > > And now there''s other tapdisk patch in xen-unstable
aswell:
> > > 
> > > "tools: Retry blktap2 tapdisk message on interrupt":
> > >
http://xenbits.xen.org/gitweb/?p=3Dxen.git;a=3Dcommit;h=3D6cffb2b469a55032a>
> > 2900ccb8776c0082f346758
> > > 
> > > Both are needed in Xen 4.2 branch, please backport/apply before
next Xen 4.> > > 2.2-rc !
> > > 
> > > I''m asking because we''ve seen these problems
with the CentOS 6 Xen 4.2 rpms,
> > > and it''d be good to get them fixed in upstream Xen 4.2
aswell.
> > 
> > Ian raised a good point with respect to the read/write system calls in
> > the blktap2 control plane needing to handle EINTR as well. 
We''ve
> > never seen this issue in the field but it should be handled.
> > 
> > I will see if I can get a patch spun today on top of my last patch to
> > add that if no one beats me to it.
> > 
> 
> Ok, thanks! So that patch is now in master/xen-unstable aswell.
> 
> IanJ: These three patches from master need to be applied to Xen 4.2 branch.
> Let''s do it now before Xen 4.2.2-rc2.
> 
> 
> "libxl: don''t launch more than one tapdisk process for each
disk":
>
http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=ec398660e89ca18bb8d061d5047d682bd383778a
> (Xen 4.2 backport:
http://lists.xen.org/archives/html/xen-devel/2013-03/msg00778.html)
> 
> "tools: Retry blktap2 tapdisk message on interrupt":
>
http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=6cffb2b469a55032a2900ccb8776c0082f346758
> 
> "tools/blktap2: Handle read/write interrupts in blktap2 control
plane.":
>
http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=a5c800142cfc82159fcb85b47116cf296caebcc5
> 
> 
> Thanks! 
> 
> 
> -- Pasi
>

Pasi Kärkkäinen writes ("Re: [Xen-devel] preparing for 4.2.2 and 4.1.5 /
libxl blktap2 patches"):
> IanJ: ping? 2/3 of the blktap2 bugfix patches listed below are not yet
applied to 4.2 branch..
> (all three patches below have passed xen-unstable/master automated tests).
It looks like I dropped two of these backport requests.

I''m afraid they didn''t make -rc2 but I think it''s
still OK to push
them to staging-4.2 so I have done so.

Regards,
Ian.

On Mon, Apr 15, 2013 at 06:17:19PM +0100, Ian Jackson
wrote:
> Pasi Kärkkäinen writes ("Re: [Xen-devel] preparing for 4.2.2 and 4.1.5
/ libxl blktap2 patches"):
> > IanJ: ping? 2/3 of the blktap2 bugfix patches listed below are not yet
applied to 4.2 branch..
> > (all three patches below have passed xen-unstable/master automated
tests).
> 
> It looks like I dropped two of these backport requests.
> 
> I''m afraid they didn''t make -rc2 but I think
it''s still OK to push
> them to staging-4.2 so I have done so.
> 
Great, thanks a lot!

-- Pasi