fantonifabio@tiscali.it
2013-Mar-18 10:59 UTC
[PATCH v2] tools/firmware: Fix ovmf build with gcc version different from 4.4
Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz> Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- tools/firmware/ovmf-makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/firmware/ovmf-makefile b/tools/firmware/ovmf-makefile index c3cd466..073ed44 100644 --- a/tools/firmware/ovmf-makefile +++ b/tools/firmware/ovmf-makefile @@ -10,7 +10,7 @@ all: ovmf.bin .PHONY: ovmf.bin ovmf.bin: OvmfPkg/build.sh -a X64 - cp Build/OvmfX64/DEBUG_GCC44/FV/OVMF.fd ovmf.bin + cp Build/OvmfX64/DEBUG_GCC*/FV/OVMF.fd ovmf.bin .PHONY: clean clean: -- 1.7.9.5
Ian Campbell
2013-Mar-18 11:26 UTC
Re: [PATCH v2] tools/firmware: Fix ovmf build with gcc version different from 4.4
On Mon, 2013-03-18 at 10:59 +0000, fantonifabio@tiscali.it wrote:> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>I don''t remember saying this, and it would have been odd for me to do so, usually I would "Acked-by" (but I don''t recall doing that either)... Please be careful since adding these S-o-b has a specific meaning. (Per the DCO, in http://wiki.xen.org/wiki/Submitting_Xen_Patches) Ian.
Ian Jackson
2013-Mar-25 12:38 UTC
[PATCH v2] tools/firmware: Fix ovmf build with gcc version different from 4.4
fantonifabio@tiscali.it writes ("[PATCH v2] tools/firmware: Fix ovmf build with gcc version different from 4.4"):> Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>I have applied this, but I have removed Ian Campbell''s S-o-b which (as he notes) you added incorrectly. Thanks, Ian.
Possibly Parallel Threads
- [PATCH] tools: ovmf debug build only if tools debug is enabled
- How to set GCC version for ovmf compilation
- Unable to add additional domain controller - uncaught exception - LDAP error 10 on join
- [PATCH] libxl: Add spice vdagent support for upstream qemu
- [PATCH] libxl: Add qxl vga interface support for upstream qemu