Jan Beulich
2013-Mar-01 16:11 UTC
[PATCH] x86: reduce irq_cpustat_t''s __softirq_pending to 32 bits
Assembly code was already only accessing the low 32 bits of it, and
we''re far away from using all 32 bits of it.
Noticed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/include/asm-x86/hardirq.h
+++ b/xen/include/asm-x86/hardirq.h
@@ -5,7 +5,7 @@
#include <xen/cache.h>
typedef struct {
- unsigned long __softirq_pending;
+ unsigned int __softirq_pending;
unsigned int __local_irq_count;
unsigned int __nmi_count;
bool_t __mwait_wakeup;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
Keir Fraser
2013-Mar-01 19:42 UTC
Re: [PATCH] x86: reduce irq_cpustat_t''s __softirq_pending to 32 bits
On 01/03/2013 16:11, "Jan Beulich" <JBeulich@suse.com> wrote:> Assembly code was already only accessing the low 32 bits of it, and > we''re far away from using all 32 bits of it. > > Noticed-by: Andrew Cooper <andrew.cooper3@citrix.com> > Signed-off-by: Jan Beulich <jbeulich@suse.com>I''d also be fine with some explicitly-sized typing here. But I don''t really care much about that either way, so: Acked-by: Keir Fraser <keir@xen.org>> --- a/xen/include/asm-x86/hardirq.h > +++ b/xen/include/asm-x86/hardirq.h > @@ -5,7 +5,7 @@ > #include <xen/cache.h> > > typedef struct { > - unsigned long __softirq_pending; > + unsigned int __softirq_pending; > unsigned int __local_irq_count; > unsigned int __nmi_count; > bool_t __mwait_wakeup; > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel