Xen devel - Feb 2013 - [PATCH 1/7] xen/arm: /spin_lock_irq/spin_lock_irqsave in gic_set_guest_irq

gic_set_guest_irq can be called with irq disabled

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
 xen/arch/arm/gic.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index 165287c..7627ad8 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -477,8 +477,9 @@ void gic_set_guest_irq(struct vcpu *v, unsigned int
virtual_irq,
 {
     int i;
     struct pending_irq *iter, *n;
+    unsigned long flags;
 
-    spin_lock_irq(&gic.lock);
+    spin_lock_irqsave(&gic.lock, flags);
 
     if ( v->is_running &&
list_empty(&v->arch.vgic.lr_pending) )
     {
@@ -505,7 +506,7 @@ void gic_set_guest_irq(struct vcpu *v, unsigned int
virtual_irq,
     list_add_tail(&n->lr_queue, &v->arch.vgic.lr_pending);
 
 out:
-    spin_unlock_irq(&gic.lock);
+    spin_unlock_irqrestore(&gic.lock, flags);
     return;
 }
 
-- 
1.7.2.5

On Thu, 2013-02-14 at 16:37 +0000, Stefano Stabellini
wrote:
> gic_set_guest_irq can be called with irq disabled
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Acked + applied #1-#5

I commented on #6 and 7.

Thanks,
Ian.